[compiler-rt][hwasan] Check for SANITIZER_POSIX before including sanitizer_posix.h

[leonardchan]

Summary

None of the functions declared in sanitizer_posix.h are needed for the Fuchsia implementation inside hwasan_dynamic_shadow.cpp.

[leonardchan]

Not sure if this is the cleanest approach, but I'll leave it up to the reviewers. This really only affects the fuchsia case which just defines an empty InitShadowGOT.

[vitalybuka]

compiler-rt/lib/hwasan/hwasan_dynamic_shadow.cpp

25 ↗

(On Diff #362456)

I believe we usually do that inside of "sanitizer_common/sanitizer_posix.h"

#include "sanitizer_platform.h"
#if SANITIZER_POSIX

#SANITIZER_POSIX

E.g. sanitizer_common/sanitizer_win.h

[vitalybuka]

LGTM if moved into sanitizer_posix.h

[leonardchan]

In D106979#2910982, @vitalybuka wrote:

LGTM if moved into sanitizer_posix.h

Done. Although before, including this header when SANITIZER_POSIX was 0 would result in the preprocessor error (shown in diff). Will still leave it up in case this changes anything, but will land this after a day or so if no further comments.

compiler-rt/lib/sanitizer_common/sanitizer_posix.h

 // ----------- ATTENTION -------------
 // This header should NOT include any other headers from sanitizer runtime.
 #include "sanitizer_internal_defs.h"
 #include "sanitizer_platform_limits_freebsd.h"
 #include "sanitizer_platform_limits_netbsd.h"
 #include "sanitizer_platform_limits_posix.h"
 #include "sanitizer_platform_limits_solaris.h"
 
-#if !SANITIZER_POSIX
-// Make it hard to accidentally use any of functions declared in this file:
-#error This file should only be included on POSIX
-#endif
+#if SANITIZER_POSIX
 
 namespace __sanitizer {
 
 // I/O
 // Don't use directly, use __sanitizer::OpenFile() instead.
 uptr internal_open(const char *filename, int flags);
 uptr internal_open(const char *filename, int flags, u32 mode);
 uptr internal_close(fd_t fd);

 int GetNamedMappingFd(const char *name, uptr size, int *flags);
 // 2. Add name to an existing anonymous mapping. The caller must keep *name
 // alive at least as long as the mapping exists.
 void DecorateMapping(uptr addr, uptr size, const char *name);
 
 
 }  // namespace __sanitizer
 
+#endif  // SANITIZER_POSIX
+
 #endif  // SANITIZER_POSIX_H