This is an archive of the discontinued LLVM Phabricator instance.

[NFC][PowerPC] Fix spe.ll to work with update_llc_test_checks.py again
ClosedPublic

Authored by jrtc27 on Jul 28 2021, 8:17 AM.

Details

Summary

Using split-file does not work with update_llc_test_checks.py. It's also
mostly redundant, as the single and double tests can just use a single
llc and FileCheck invocation for each FPU type using -check-prefixes
rather than -check-prefix, and update_llc_test_checks.py will merge what
it can. Only test_dasmconst needs to be SPE-only and so is pulled out
into its own mall file (rather than using sed to preprocess the file and
keep it commented out for EFPU2, which would work, but is ugly).

As well as cutting down on the number of RUN lines, this also results in
test_fma's CHECK lines being merged for both FPUs.

Diff Detail

Event Timeline

jrtc27 created this revision.Jul 28 2021, 8:17 AM
jrtc27 requested review of this revision.Jul 28 2021, 8:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2021, 8:17 AM
kiausch accepted this revision.Jul 28 2021, 8:28 AM

Looks good to me!

This revision is now accepted and ready to land.Jul 28 2021, 8:28 AM
This revision was landed with ongoing or failed builds.Jul 28 2021, 9:13 AM
This revision was automatically updated to reflect the committed changes.