This is an archive of the discontinued LLVM Phabricator instance.

Differential D106952

tsan: extend signal_malloc test
ClosedPublic

Authored by dvyukov on Jul 28 2021, 6:03 AM.

Details

Reviewers
vitalybuka
melver
Commits
rG9ef9d01a5046: tsan: extend signal_malloc test
Summary

Test that we report the warning for free()
and ensure the test finishes as we usually do with "DONE".

Depends on D106951.

Diff Detail

Event Timeline

dvyukov requested review of this revision.Jul 28 2021, 6:03 AM
dvyukov created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2021, 6:03 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
dvyukov added a child revision: D106953: tsan: increase max number of threads supported by test-only barrier.Jul 28 2021, 6:03 AM
Harbormaster completed remote builds in B116668: Diff 362350.Jul 28 2021, 6:41 AM
melver accepted this revision.Jul 28 2021, 7:40 AM
This revision is now accepted and ready to land.Jul 28 2021, 7:40 AM
Closed by commit rG9ef9d01a5046: tsan: extend signal_malloc test (authored by dvyukov). · Explain WhyJul 28 2021, 8:35 AM
This revision was automatically updated to reflect the committed changes.
dvyukov added a commit: rG9ef9d01a5046: tsan: extend signal_malloc test.

Revision Contents

PathSize
compiler-rt/
test/
tsan/
6 lines

Diff 362350

compiler-rt/test/tsan/signal_malloc.cpp

// RUN: %clang_tsan -O1 %s -o %t && %deflake %run %t | FileCheck %s // RUN: %clang_tsan -O1 %s -o %t && %deflake %run %t | FileCheck %s
#include "test.h" #include "test.h"
#include <signal.h> #include <signal.h>
#include <sys/types.h> #include <sys/types.h>
static void handler(int, siginfo_t*, void*) { static void handler(int, siginfo_t*, void*) {
// CHECK: WARNING: ThreadSanitizer: signal-unsafe call inside of a signal // CHECK: WARNING: ThreadSanitizer: signal-unsafe call inside of a signal
// CHECK: #0 malloc // CHECK: #0 malloc
// CHECK: #{{(1|2)}} handler(int, {{(__)?}}siginfo{{(_t)?}}*, void*) {{.*}}signal_malloc.cpp:[[@LINE+2]] // CHECK: #{{(1|2)}} handler(int, {{(__)?}}siginfo{{(_t)?}}*, void*) {{.*}}signal_malloc.cpp:[[@LINE+2]]
// CHECK: SUMMARY: ThreadSanitizer: signal-unsafe call inside of a signal{{.*}}handler // CHECK: SUMMARY: ThreadSanitizer: signal-unsafe call inside of a signal{{.*}}handler
volatile char *p = (char*)malloc(1); volatile char *p = (char*)malloc(1);
p[0] = 0; p[0] = 0;
// CHECK: WARNING: ThreadSanitizer: signal-unsafe call inside of a signal
// CHECK: #0 free
// CHECK: #{{(1|2)}} handler(int, {{(__)?}}siginfo{{(_t)?}}*, void*) {{.*}}signal_malloc.cpp:[[@LINE+2]]
// CHECK: SUMMARY: ThreadSanitizer: signal-unsafe call inside of a signal{{.*}}handler
free((void*)p); free((void*)p);
} }
int main() { int main() {
struct sigaction act = {}; struct sigaction act = {};
act.sa_sigaction = &handler; act.sa_sigaction = &handler;
sigaction(SIGPROF, &act, 0); sigaction(SIGPROF, &act, 0);
kill(getpid(), SIGPROF); kill(getpid(), SIGPROF);
sleep(1); // let the signal handler run sleep(1); // let the signal handler run
fprintf(stderr, "DONE\n");
// CHECK: DONE
return 0; return 0;
} }