tsan: fix warnings in tests

[dvyukov]

Summary

Compilers don't like attributes in this position:

warning: GCC does not allow 'noinline' attribute in this position on a function definition
error: attributes are not allowed on a function-definition

compiler-rt/test/tsan/ignorelist2.cpp

void *Thread1(void *x) {
   barrier_wait(&barrier);
   // CHECK: ThreadSanitizer: data race
   // CHECK: Write of size 4
   // CHECK: #0 Thread1{{.*}}ignorelist2.cpp:[[@LINE+1]]
   Global++;
   return NULL;
 }
 
-void TouchGlobal() __attribute__((noinline)) {
+__attribute__((noinline)) void TouchGlobal() {
   // CHECK: Previous write of size 4
   // CHECK: #0 TouchGlobal{{.*}}ignorelist2.cpp:[[@LINE+1]]
   Global--;
 }
 
-void CallTouchGlobal() __attribute__((noinline)) {
+__attribute__((noinline)) void CallTouchGlobal() {
   // CHECK: #1 CallTouchGlobal{{.*}}ignorelist2.cpp:[[@LINE+1]]
   TouchGlobal();
 }
 
 void *Ignorelisted_Thread2(void *x) {
   Global--;
   // CHECK: #2 Ignorelisted_Thread2{{.*}}ignorelist2.cpp:[[@LINE+1]]
   CallTouchGlobal();

compiler-rt/test/tsan/longjmp3.cpp

 }
 
 void foo(jmp_buf env) {
   volatile int x = 42;
   bar(env);
   x++;
 }
 
-void badguy() __attribute__((noinline)) {
+__attribute__((noinline)) void badguy() {
   pthread_mutex_t mtx;
   pthread_mutex_init(&mtx, 0);
   pthread_mutex_lock(&mtx);
   pthread_mutex_destroy(&mtx);
 }
 
-void mymain() __attribute__((noinline)) {
+__attribute__((noinline)) void mymain() {
   jmp_buf env;
   if (setjmp(env) == 42) {
     badguy();
     return;
   }
   foo(env);
   fprintf(stderr, "FAILED\n");
 }

compiler-rt/test/tsan/longjmp4.cpp

 }
 
 void foo(jmp_buf env) {
   volatile int x = 42;
   bar(env);
   x++;
 }
 
-void badguy() __attribute__((noinline)) {
+__attribute__((noinline)) void badguy() {
   pthread_mutex_t mtx;
   pthread_mutex_init(&mtx, 0);
   pthread_mutex_lock(&mtx);
   pthread_mutex_destroy(&mtx);
 }
 
-void mymain() __attribute__((noinline)) {
+__attribute__((noinline)) void mymain() {
   jmp_buf env;
   if (setjmp(env) == 42) {
     badguy();
     return;
   }
   foo(env);
   fprintf(stderr, "FAILED\n");
 }

compiler-rt/test/tsan/race_on_heap.cpp

 // RUN: %clangxx_tsan -O1 %s -o %t && %deflake %run %t | FileCheck %s
 #include <pthread.h>
 #include <stdlib.h>
 #include <stdio.h>
 #include "test.h"
 
 void *Thread1(void *p) {
   *(int*)p = 42;
   return 0;
 }
 
 void *Thread2(void *p) {
   *(int*)p = 44;
   return 0;
 }
 
-void *alloc() __attribute__((noinline)) {
+__attribute__((noinline)) void *alloc() {
   return malloc(99);
 }
 
 void *AllocThread(void* arg) {
   return alloc();
 }
 
 int main() {

compiler-rt/test/tsan/race_top_suppression.cpp

 // RUN: echo "race_top:TopFunction" > %t.supp
 // RUN: %clangxx_tsan -O1 %s -o %t
 // RUN: %env_tsan_opts=suppressions='%t.supp' %run %t 2>&1 | FileCheck %s
 // RUN: rm %t.supp
 #include "test.h"
 
 int Global;
 
-void TopFunction(int *p) __attribute__((noinline)) {
+__attribute__((noinline)) void TopFunction(int *p) {
   *p = 1;
 }
 
 void *Thread(void *x) {
   barrier_wait(&barrier);
   TopFunction(&Global);
   return 0;
 }