This is an archive of the discontinued LLVM Phabricator instance.

[Analysis] Fix getOrderedReductionCost to call target's getArithmeticInstrCost implementation
ClosedPublic

Authored by RKSimon on Jul 26 2021, 8:10 AM.

Details

Summary

The getOrderedReductionCost implementation introduced in D105432 calls the CRTP base version getArithmeticInstrCost instead of the redirecting to the target version.

Diff Detail

Event Timeline

RKSimon requested review of this revision.Jul 26 2021, 8:10 AM
RKSimon created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJul 26 2021, 8:10 AM
RKSimon added inline comments.Jul 26 2021, 8:11 AM
llvm/include/llvm/CodeGen/BasicTTIImpl.h
2093

Just to be clear - this getScalarizationOverhead call isn't replaced by a target version, its just a base class wrapper that calls the target's DemandedElts variant of getScalarizationOverhead

david-arm accepted this revision.Jul 26 2021, 8:13 AM

LGTM! Thanks for fixing my bug. :)

This revision is now accepted and ready to land.Jul 26 2021, 8:13 AM
This revision was landed with ongoing or failed builds.Jul 26 2021, 9:16 AM
This revision was automatically updated to reflect the committed changes.