This is an archive of the discontinued LLVM Phabricator instance.

[libomptarget][amdgpu] Remove call into hsa that follows failing to init hsa
AbandonedPublic

Authored by JonChesterfield on Jul 25 2021, 1:19 PM.

Details

Reviewers
jdoerfert
Summary

[libomptarget][amdgpu] Remove call into hsa that follows failing to init hsa

The call in rtl.cpp carefully avoids calling into hsa to find out why it can't call
into hsa, but the call nested within system.cpp did not. Given the failure is reported
anyway, drop the printf. Also drop an adjacent block that looks like a merge failure.

Reported by jdoerfert

Diff Detail

Event Timeline

JonChesterfield requested review of this revision.Jul 25 2021, 1:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 25 2021, 1:19 PM

Same problem for the RTLDeviceInfoTy destructor. let's fix both together.

sure, can roll them together

JonChesterfield abandoned this revision.Jul 25 2021, 1:45 PM