This is an archive of the discontinued LLVM Phabricator instance.

[LLDB][GUI] Add Platform Plugin Field
ClosedPublic

Authored by OmarEmaraDev on Jul 21 2021, 12:54 PM.

Details

Summary

This patch adds a new Platform Plugin Field. It is a choices field that
lists all the available platform plugins and can retrieve the name of the
selected plugin. The default selected plugin is the currently selected
one. This patch also allows for arbitrary scrolling to make scrolling
easier when setting choices.

Diff Detail

Event Timeline

OmarEmaraDev created this revision.Jul 21 2021, 12:54 PM
OmarEmaraDev requested review of this revision.Jul 21 2021, 12:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 21 2021, 12:54 PM
clayborg accepted this revision.Jul 21 2021, 2:44 PM
This revision is now accepted and ready to land.Jul 21 2021, 2:44 PM
clayborg requested changes to this revision.Jul 21 2021, 2:46 PM

Actually this doesn't apply cleanly to top of tree right now. Can you resolve the conflicts and update the patch? Two other of your patches recently have been committed.

This revision now requires changes to proceed.Jul 21 2021, 2:46 PM
  • Rebase on main and fix conflicts.
clayborg accepted this revision.Jul 23 2021, 5:59 PM
This revision is now accepted and ready to land.Jul 23 2021, 5:59 PM
This revision was landed with ongoing or failed builds.Jul 23 2021, 6:00 PM
This revision was automatically updated to reflect the committed changes.