This is an archive of the discontinued LLVM Phabricator instance.

[flang][driver] Make `flang` ignore `-Mfree/-Mfixed`
ClosedPublic

Authored by awarzynski on Jul 21 2021, 2:09 AM.

Details

Summary

-Mfixed is not supported by the new driver and hence
flang, the bash wrapper script, forwards it to the host compiler.
The forwarded options are used by the host compiler when compiling the
unparsed files. As the unparsed source files are always in the free
form, forwarding -Mfixed is problematic.

With this patch, -Mfixed (and -Mfree for consistency) will be
ignored altogether. The user will only see a warning. This is not a
particularly sound approach, but flang is only a temporary solution
for us and this workaround is a fair compromise.

Diff Detail

Event Timeline

awarzynski created this revision.Jul 21 2021, 2:09 AM
awarzynski requested review of this revision.Jul 21 2021, 2:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 21 2021, 2:09 AM
awarzynski added a project: Restricted Project.
This revision is now accepted and ready to land.Jul 21 2021, 2:45 AM
sscalpone requested changes to this revision.Jul 22 2021, 12:46 AM
sscalpone added inline comments.
flang/tools/f18/flang.in
218

I don't think there's a need for a warning. The throwaway driver dropped these options too.

This revision now requires changes to proceed.Jul 22 2021, 12:46 AM

Remove the warning

sscalpone accepted this revision.Jul 27 2021, 12:05 AM

Looks good! Thanks

This revision is now accepted and ready to land.Jul 27 2021, 12:05 AM
This revision was automatically updated to reflect the committed changes.