[llvm-symbolizer] Remove one-dash long options

[MaskRay]

Summary

Most modern tools only accept two-dash long options. Remove one-dash
long options which are not recognized by GNU style getopt_long.
This ensures long options cannot collide with grouped short options.

Note: llvm-symbolizer has -demangle={true,false} for pprof compatibility
(for a while). They are kept.

[MaskRay]

fix tests

[jhenderson]

Looks fine to me.

llvm/test/tools/llvm-symbolizer/pdb/missing_pdb.test

-RUN: llvm-symbolizer 0x401000 0x401001 -obj="%p/Inputs/missing_pdb.exe" 2>%t.err \
+RUN: llvm-symbolizer 0x401000 0x401001 --obj="%p/Inputs/missing_pdb.exe" 2>%t.err \
 RUN:    | FileCheck %s
 RUN: FileCheck -DMSG=%errc_ENOENT --check-prefix=ERROR %s < %t.err
 
 llvm-symbolizer should print one error and two unknown line info records.
 
 ERROR: LLVMSymbolizer: error reading file: {{.*}}: [[MSG]]
 ERROR-NOT: error reading file
 
 CHECK: ??
 CHECK: ??:0:0
 CHECK: ??
 CHECK: ??:0:0

llvm/test/tools/llvm-symbolizer/pdb/pdb-columns.test

 RUN: echo 0x140006BA0 > %t.input
 RUN: echo 0x140006C00 >> %t.input
 RUN: echo 0x140006BB0 >> %t.input
 RUN: echo 0x140006C10 >> %t.input
 RUN: echo 0x140006C20 >> %t.input
 RUN: echo 0x140006C30 >> %t.input
 RUN: echo 0x140006C40 >> %t.input
 RUN: echo 0x140006C70 >> %t.input
-RUN:    llvm-symbolizer -obj="%p/Inputs/test-columns.exe" < %t.input \
+RUN:    llvm-symbolizer --obj="%p/Inputs/test-columns.exe" < %t.input \
 RUN:    | FileCheck %s
 
 This tests that the symbolizer outputs column info when it is present in the pdb.
 
 CHECK: foo(void)
 CHECK-NEXT: test.cpp:11:1
 CHECK: {{^private_symbol$}}
 CHECK-NEXT: test.cpp:14:1

llvm/tools/llvm-symbolizer/Opts.td

 include "llvm/Option/OptParser.td"
 
 multiclass B<string name, string help1, string help2> {
-  def NAME: Flag<["--", "-"], name>, HelpText<help1>;
-  def no_ # NAME: Flag<["--", "-"], "no-" # name>, HelpText<help2>;
+  def NAME: Flag<["--"], name>, HelpText<help1>;
+  def no_ # NAME: Flag<["--"], "no-" # name>, HelpText<help2>;
 }
 
 multiclass Eq<string name, string help> {
-  def NAME #_EQ : Joined<["--", "-"], name #"=">,
+  def NAME #_EQ : Joined<["--"], name #"=">,
                   HelpText<help>;
-  def : Separate<["--", "-"], name>, Alias<!cast<Joined>(NAME #_EQ)>;
+  def : Separate<["--"], name>, Alias<!cast<Joined>(NAME #_EQ)>;
 }
 
-class F<string name, string help>: Flag<["--", "-"], name>, HelpText<help>;
+class F<string name, string help>: Flag<["--"], name>, HelpText<help>;
 
 def grp_mach_o : OptionGroup<"kind">,
                  HelpText<"llvm-symbolizer Mach-O Specific Options">;
 
 def addresses : F<"addresses", "Show address before line information">;
 defm adjust_vma
     : Eq<"adjust-vma", "Add specified offset to object file addresses">,
       MetaVarName<"<offset>">;