This is an archive of the discontinued LLVM Phabricator instance.

[Utils] Add -compilation-dir flag to prepare-code-coverage-artifact.py
ClosedPublic

Authored by zequanwu on Jul 19 2021, 2:27 PM.

Diff Detail

Event Timeline

zequanwu requested review of this revision.Jul 19 2021, 2:27 PM
zequanwu created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJul 19 2021, 2:27 PM
zequanwu updated this revision to Diff 359923.Jul 19 2021, 2:40 PM

Add the flag only if it's non-empty.

thakis accepted this revision.Jul 19 2021, 5:18 PM

Thanks! I patched this in and tried it, it works for me.

llvm/utils/prepare-code-coverage-artifact.py
94

Should this support -C as short flag too?

This revision is now accepted and ready to land.Jul 19 2021, 5:18 PM
vsk accepted this revision.Jul 20 2021, 10:15 AM
zequanwu updated this revision to Diff 360207.Jul 20 2021, 10:55 AM
zequanwu marked an inline comment as done.

Add short flag "-C".

This revision was landed with ongoing or failed builds.Jul 20 2021, 10:56 AM
This revision was automatically updated to reflect the committed changes.
thakis added a comment.Nov 5 2021, 7:40 AM

Very belated comment: It's a bit weird that index.html has paths like ../../lld/COFF/COFFLinkerContext.cpp but if you click it the generated file for that starts with lld/COFF/COFFLinkerContext.cpp.

Without --compilation-dir and -fcoverage-compilation-dir=. it's also inconsistent (../../lld/COFF/COFFLinkerContext.cpp and /Users/thakis/src/llvm-project/lld/COFF/COFFLinkerContext.cpp) so it's not a new thing from this flag. But maybe it'd be nice if index and detail page used the same string? Not sure.

(Feel free to ignore this comment; just thought I should mention this discrepancy somewhere.)