This is an archive of the discontinued LLVM Phabricator instance.

[NFC][PowerPC] Update builtins-ppc-altivec.c to be run under `-faltivec-src-compat=mixed`
ClosedPublic

Authored by amyk on Jul 19 2021, 7:57 AM.

Details

Summary

This patch adds the -faltivec-src-compat=mixed option to the builtins-ppc-altivec.c test.

Currently, the default for -faltivec-src-compat is mixed. The reason we explicitly specify mixed
to the RUN lines of this test is because eventually, the default will set to xl.

Having the default as xl changes the CHECKs of this test slightly, as it reorders some of the
vector bool and vector pixel CHECKs (since under the xl option, vector bool and vector pixel
are treated in the same way as other vector scalars). Explicitly specifying mixed ensures that
we are testing pre-existing Clang behaviour.

Diff Detail

Event Timeline

amyk created this revision.Jul 19 2021, 7:57 AM
amyk requested review of this revision.Jul 19 2021, 7:57 AM
nemanjai accepted this revision.Jul 19 2021, 8:37 AM

LGTM. Please don't forget to mark this as NFC in the title.

This revision is now accepted and ready to land.Jul 19 2021, 8:37 AM
amyk retitled this revision from [PowerPC] Update builtins-ppc-altivec.c to be run under `-faltivec-src-compat=mixed` to [NFC][PowerPC] Update builtins-ppc-altivec.c to be run under `-faltivec-src-compat=mixed`.Jul 19 2021, 9:16 AM
This revision was landed with ongoing or failed builds.Jul 19 2021, 9:20 AM
This revision was automatically updated to reflect the committed changes.