Page MenuHomePhabricator

[mlir] add an interface to support custom types in LLVM dialect pointers
ClosedPublic

Authored by ftynse on Jul 15 2021, 9:23 AM.

Details

Summary

This may be necessary in partial multi-stage conversion when a container type
from dialect A containing types from dialect B goes through the conversion
where only dialect A is converted to the LLVM dialect. We will need to keep a
pointer-to-non-LLVM type in the IR until a further conversion can convert
dialect B types to LLVM types.

Diff Detail

Event Timeline

ftynse created this revision.Jul 15 2021, 9:23 AM
ftynse requested review of this revision.Jul 15 2021, 9:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 15 2021, 9:23 AM
wsmoses accepted this revision.Jul 15 2021, 4:40 PM
wsmoses added inline comments.
mlir/include/mlir/Dialect/LLVMIR/LLVMOpsInterfaces.td
26–27

Change on this line seems unnecessary. Probably best to preserve as is, unless the formatting is explicitly preferred.

This revision is now accepted and ready to land.Jul 15 2021, 4:40 PM
ftynse marked an inline comment as done.Jul 16 2021, 4:05 AM
ftynse added inline comments.
mlir/include/mlir/Dialect/LLVMIR/LLVMOpsInterfaces.td
26–27

It is preferred.

This revision was landed with ongoing or failed builds.Jul 16 2021, 4:05 AM
This revision was automatically updated to reflect the committed changes.
ftynse marked an inline comment as done.