This is an archive of the discontinued LLVM Phabricator instance.

[ASTMatchers] NFC: Fix the annotation.

Authored by Sockke on Jul 14 2021, 5:35 AM.



The annotation about ignoringImpCasts is wrong, which will cause misunderstanding. Fix it.


Diff Detail

Event Timeline

Sockke requested review of this revision.Jul 14 2021, 5:35 AM
Sockke created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJul 14 2021, 5:35 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

The change looks good to me, but you need to regenerate the documentation manually. You can do so by running clang/docs/tools/

Sockke updated this revision to Diff 358820.Jul 14 2021, 7:57 PM
Sockke edited the summary of this revision. (Show Details)

Thanks for your review! I have run clang/docs/tools/ to regenerate the documentation.

MTC accepted this revision.Jul 14 2021, 8:05 PM

LGTM, thanks for your cleanup.

This revision is now accepted and ready to land.Jul 14 2021, 8:05 PM
Sockke updated this revision to Diff 358835.Jul 14 2021, 8:48 PM

update to display context.

aaron.ballman accepted this revision.Jul 15 2021, 3:46 AM

LGTM, thank you for the fix! Do you need me to commit it on your behalf? If so, what name and email address would you like me to use for patch attribution?

I would appreciate it if you could submit it on my behalf. Thanks a lot!

Name: liuke

aaron.ballman closed this revision.Jul 15 2021, 6:40 AM

Thank you for the patch! I've commit on your behalf in 034b94bb7161c64234e4ec35bf49428c3a1f8f0a.