Page MenuHomePhabricator

Sockke (gehry)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 20 2021, 1:55 AM (61 w, 6 d)

Recent Activity

Today

Sockke updated the diff for D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init.

rebased.

Tue, Jun 28, 1:13 AM · Restricted Project, Restricted Project

Yesterday

Sockke requested review of D128697: [clang-tidy] Add new check `bugprone-unhandled-exception-at-sto`.
Mon, Jun 27, 11:14 PM · Restricted Project, Restricted Project

Mon, Jun 20

Sockke updated the diff for D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init.

rebased.

Mon, Jun 20, 1:54 AM · Restricted Project, Restricted Project

Wed, Jun 8

Sockke updated the diff for D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init.

Fix test file.

Wed, Jun 8, 8:01 PM · Restricted Project, Restricted Project
Sockke set the repository for D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init to rG LLVM Github Monorepo.
Wed, Jun 8, 5:03 AM · Restricted Project, Restricted Project
Sockke requested review of D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init.
Wed, Jun 8, 5:03 AM · Restricted Project, Restricted Project

Sun, May 29

Sockke committed rG3f3a235aa2e6: [clang-apply-replacements] Added an option to ignore insert conflict. (authored by Sockke).
[clang-apply-replacements] Added an option to ignore insert conflict.
Sun, May 29, 10:05 PM · Restricted Project, Restricted Project, Restricted Project
Sockke closed D123924: [clang-apply-replacements] Added an option to ignore insert conflict..
Sun, May 29, 10:05 PM · Restricted Project, Restricted Project, Restricted Project
Sockke updated the diff for D123924: [clang-apply-replacements] Added an option to ignore insert conflict..
Sun, May 29, 8:28 PM · Restricted Project, Restricted Project, Restricted Project
Sockke committed rGc98b3a8cd985: Fix `performance-unnecessary-value-param` for template specialization (authored by Sockke).
Fix `performance-unnecessary-value-param` for template specialization
Sun, May 29, 6:56 PM · Restricted Project, Restricted Project
Sockke closed D116593: Fix `performance-unnecessary-value-param` for template specialization.
Sun, May 29, 6:56 PM · Restricted Project, Restricted Project

May 27 2022

Sockke updated the diff for D123924: [clang-apply-replacements] Added an option to ignore insert conflict..

rebased.

May 27 2022, 4:41 AM · Restricted Project, Restricted Project, Restricted Project
Sockke updated the diff for D116593: Fix `performance-unnecessary-value-param` for template specialization.

Rebased and added '-fno-delayed-template-parsing' option for the test file.

May 27 2022, 4:18 AM · Restricted Project, Restricted Project

May 19 2022

Sockke added a comment to D116593: Fix `performance-unnecessary-value-param` for template specialization.

I'm not quite sure why the test case is not passing on Windows, could you please check this problem? Thanks for your assistance. @flx

May 19 2022, 5:09 AM · Restricted Project, Restricted Project
Sockke added a comment to D123924: [clang-apply-replacements] Added an option to ignore insert conflict..

Hi, Could anyone please review this diff?

May 19 2022, 3:10 AM · Restricted Project, Restricted Project, Restricted Project
Sockke updated the diff for D116593: Fix `performance-unnecessary-value-param` for template specialization.

rebased.

May 19 2022, 3:06 AM · Restricted Project, Restricted Project

May 8 2022

Sockke added a comment to D123924: [clang-apply-replacements] Added an option to ignore insert conflict..

Friendly ping.

May 8 2022, 11:33 PM · Restricted Project, Restricted Project, Restricted Project
Sockke added a reviewer for D123924: [clang-apply-replacements] Added an option to ignore insert conflict.: njames93.
May 8 2022, 11:32 PM · Restricted Project, Restricted Project, Restricted Project

Apr 28 2022

Sockke added a comment to D123924: [clang-apply-replacements] Added an option to ignore insert conflict..

Friendly ping.

Apr 28 2022, 7:28 AM · Restricted Project, Restricted Project, Restricted Project

Apr 26 2022

Sockke updated the diff for D123924: [clang-apply-replacements] Added an option to ignore insert conflict..

Rename the function.

Apr 26 2022, 3:24 AM · Restricted Project, Restricted Project, Restricted Project

Apr 18 2022

Sockke updated the diff for D123924: [clang-apply-replacements] Added an option to ignore insert conflict..
Apr 18 2022, 5:04 AM · Restricted Project, Restricted Project, Restricted Project
Sockke added a comment to D123924: [clang-apply-replacements] Added an option to ignore insert conflict..

It stands to reason that there should be no insert conflicts in the YAML generated by clang-tidy except for the header insertion. The two checks that caused the conflict should be fixed in clang-tidy.

Apr 18 2022, 4:43 AM · Restricted Project, Restricted Project, Restricted Project
Sockke updated the diff for D123924: [clang-apply-replacements] Added an option to ignore insert conflict..

Added an option to ignore insert conflict and this option was enabled by default in run-clang-tidy.py.

Apr 18 2022, 4:29 AM · Restricted Project, Restricted Project, Restricted Project
Sockke retitled D123924: [clang-apply-replacements] Added an option to ignore insert conflict. from [clang-apply-replacements] Added support for adjusting conflict offset. to [WIP][clang-apply-replacements] Added support for adjusting conflict offset..
Apr 18 2022, 3:34 AM · Restricted Project, Restricted Project, Restricted Project
Sockke updated the summary of D123924: [clang-apply-replacements] Added an option to ignore insert conflict..
Apr 18 2022, 12:59 AM · Restricted Project, Restricted Project, Restricted Project
Sockke requested review of D123924: [clang-apply-replacements] Added an option to ignore insert conflict..
Apr 18 2022, 12:56 AM · Restricted Project, Restricted Project, Restricted Project

Mar 2 2022

Sockke updated the diff for D116593: Fix `performance-unnecessary-value-param` for template specialization.
Mar 2 2022, 12:47 AM · Restricted Project, Restricted Project
Sockke updated the diff for D116593: Fix `performance-unnecessary-value-param` for template specialization.
Mar 2 2022, 12:29 AM · Restricted Project, Restricted Project

Mar 1 2022

Sockke committed rGba54ebeb5eba: [clang-tidy] Fix `readability-const-return-type` for pure virtual function. (authored by Sockke).
[clang-tidy] Fix `readability-const-return-type` for pure virtual function.
Mar 1 2022, 4:59 AM
Sockke closed D116439: [clang-tidy] Fix `readability-const-return-type` for pure virtual function..
Mar 1 2022, 4:59 AM · Restricted Project
Sockke updated the diff for D116439: [clang-tidy] Fix `readability-const-return-type` for pure virtual function..
Mar 1 2022, 4:51 AM · Restricted Project

Feb 27 2022

Sockke updated the diff for D116593: Fix `performance-unnecessary-value-param` for template specialization.

Added a release note.

Feb 27 2022, 7:49 PM · Restricted Project, Restricted Project
Sockke updated the diff for D116439: [clang-tidy] Fix `readability-const-return-type` for pure virtual function..

Added a release note.

Feb 27 2022, 7:01 PM · Restricted Project

Feb 25 2022

Sockke updated the diff for D116439: [clang-tidy] Fix `readability-const-return-type` for pure virtual function..

Removed the fix for the virtual function.

Feb 25 2022, 3:34 AM · Restricted Project
Sockke updated the diff for D116593: Fix `performance-unnecessary-value-param` for template specialization.

Removed the fix for the template.

Feb 25 2022, 12:17 AM · Restricted Project, Restricted Project

Feb 24 2022

Sockke committed rG6cbf15e9b5ac: [clang-tidy] Fix `readability-non-const-parameter` for parameter referenced by… (authored by Sockke).
[clang-tidy] Fix `readability-non-const-parameter` for parameter referenced by…
Feb 24 2022, 11:06 PM
Sockke closed D117090: [clang-tidy] Fix `readability-non-const-parameter` for parameter referenced by an lvalue.
Feb 24 2022, 11:06 PM · Restricted Project
Sockke updated the diff for D117090: [clang-tidy] Fix `readability-non-const-parameter` for parameter referenced by an lvalue.

rebased.

Feb 24 2022, 6:57 PM · Restricted Project

Feb 23 2022

Sockke added inline comments to D117090: [clang-tidy] Fix `readability-non-const-parameter` for parameter referenced by an lvalue.
Feb 23 2022, 6:56 PM · Restricted Project
Sockke updated the diff for D117090: [clang-tidy] Fix `readability-non-const-parameter` for parameter referenced by an lvalue.

Add a release note and improve test description information.

Feb 23 2022, 2:38 AM · Restricted Project

Jan 20 2022

Sockke added a comment to D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg.

Do you need someone to commit on your behalf?

Jan 20 2022, 10:36 PM · Restricted Project
Sockke committed rGa7f8aea71485: [clang-tidy] Fix wrong FixIt in performance-move-const-arg (authored by Sockke).
[clang-tidy] Fix wrong FixIt in performance-move-const-arg
Jan 20 2022, 10:31 PM
Sockke closed D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg.
Jan 20 2022, 10:31 PM · Restricted Project

Jan 19 2022

Sockke updated the diff for D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg.

Improve some description.

Jan 19 2022, 6:28 PM · Restricted Project

Jan 17 2022

Sockke accepted D115124: [clang-tidy] Fix `readability-container-size-empty` check for smart pointers.

Thanks for improving this check! I think it looks great and safe enough. It would be better to turn !(*ptr).empty() into !ptr->empty(), but I have no particular opinions at this point. Let's see if @aaron.ballman has any comments.

Jan 17 2022, 11:32 PM · Restricted Project, Restricted Project

Jan 14 2022

Sockke added inline comments to D117090: [clang-tidy] Fix `readability-non-const-parameter` for parameter referenced by an lvalue.
Jan 14 2022, 3:38 AM · Restricted Project
Sockke added a comment to D116593: Fix `performance-unnecessary-value-param` for template specialization.

Friendly ping.

Jan 14 2022, 3:34 AM · Restricted Project, Restricted Project
Sockke added a comment to D116439: [clang-tidy] Fix `readability-const-return-type` for pure virtual function..

Friendly ping. @aaron.ballman

Jan 14 2022, 3:33 AM · Restricted Project
Sockke added a comment to D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg.

Friendly ping. @aaron.ballman

Jan 14 2022, 3:32 AM · Restricted Project

Jan 12 2022

Sockke requested review of D117090: [clang-tidy] Fix `readability-non-const-parameter` for parameter referenced by an lvalue.
Jan 12 2022, 12:11 AM · Restricted Project

Jan 7 2022

Sockke added inline comments to D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg.
Jan 7 2022, 1:21 AM · Restricted Project
Sockke updated the diff for D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg.

Add some checks for null and comments for codes.

Jan 7 2022, 1:16 AM · Restricted Project

Jan 4 2022

Sockke added a comment to D116593: Fix `performance-unnecessary-value-param` for template specialization.

Thanks for your review!

Jan 4 2022, 7:44 PM · Restricted Project, Restricted Project
Sockke requested review of D116593: Fix `performance-unnecessary-value-param` for template specialization.
Jan 4 2022, 4:29 AM · Restricted Project, Restricted Project

Dec 31 2021

Sockke requested review of D116439: [clang-tidy] Fix `readability-const-return-type` for pure virtual function..
Dec 31 2021, 3:42 AM · Restricted Project

Dec 28 2021

Sockke added inline comments to D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg.
Dec 28 2021, 3:48 AM · Restricted Project
Sockke updated the diff for D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg.

Sorry for the late reply. I made improvements to the patch in response to the questions you raised. @aaron.ballman

Dec 28 2021, 3:41 AM · Restricted Project

Dec 24 2021

Sockke requested changes to D115124: [clang-tidy] Fix `readability-container-size-empty` check for smart pointers.

Could you please add a test case where the smart pointer object is dereferenced before calling size()? E.g. return (*ptr).size() == 0;. I think this change doesn't work on this test case.

Dec 24 2021, 2:05 AM · Restricted Project, Restricted Project
Sockke added a reviewer for D115124: [clang-tidy] Fix `readability-container-size-empty` check for smart pointers: Sockke.
Dec 24 2021, 1:53 AM · Restricted Project, Restricted Project

Dec 9 2021

Sockke added a comment to D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg.

Kindly ping. @aaron.ballman

Dec 9 2021, 3:38 AM · Restricted Project

Nov 26 2021

Sockke added a comment to D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg.

This generally looks fine for me, but I'd rather have other people who are more knowledgeable about the standard's intricacies looked at it too.

AFAIK Aaron is busy this week and the next (?) due to C++ Committee meetings, or something like that. And I bet after such meetings everyone would take a few more days off from looking at C++ stuff.

Nov 26 2021, 12:31 AM · Restricted Project
Sockke added a comment to D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg.

Hi, Could anyone please review this diff? @whisperity, @aaron.ballman

Nov 26 2021, 12:14 AM · Restricted Project

Nov 19 2021

Sockke added a comment to D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg.

Kindly ping. @whisperity

Nov 19 2021, 3:34 AM · Restricted Project

Nov 5 2021

Sockke added a comment to D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg.

Kindly ping. @whisperity

Nov 5 2021, 6:36 AM · Restricted Project

Nov 4 2021

Sockke updated subscribers of D113148: Add new clang-tidy check for string_view(nullptr).

This seems to be an existing check. Have you compared it with bugprone-string-constructor?

Thanks for the suggestion! From what I can tell, bugprone-string-constructor check only has warnings and does not provide fixes in most cases. The goal of bugprone-stringview-nullptr is to robustly enumerate the many cases that it cares about and provide fixes. For that reason, I think making it a separate check is best.

Nov 4 2021, 7:43 AM · Restricted Project
Sockke updated the diff for D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg.

In addition, the splicing logics of "FunctionName" and "ExpectParmTypeName" were improved.

Nov 4 2021, 6:28 AM · Restricted Project
Sockke updated the diff for D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg.

I improved the logic of judgments needing to report suggesting notes in some cases. And more tests were added here.

Nov 4 2021, 5:03 AM · Restricted Project

Nov 3 2021

Sockke added a comment to D113148: Add new clang-tidy check for string_view(nullptr).

This seems to be an existing check. Have you compared it with bugprone-string-constructor?

Nov 3 2021, 8:04 PM · Restricted Project

Oct 27 2021

Sockke added a comment to D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg.

I think this is becoming okay and looks safe enough. I can't really grasp what HasCheckedMoveSet means, and how it synergises with storing CallExprs so maybe a better name should be added. Do you mean AlreadyCheckedMoves? When is it possible that the same CallExpr of std::move will be matched multiple times?

Oct 27 2021, 6:01 AM · Restricted Project
Sockke updated the diff for D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg.

Update!

Oct 27 2021, 5:58 AM · Restricted Project

Oct 26 2021

Sockke added a reviewer for D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg: steveire.
Oct 26 2021, 5:35 AM · Restricted Project
Sockke added a comment to D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg.

Kindly ping. @whisperity, @aaron.ballman, @Quuxplusone

Oct 26 2021, 5:27 AM · Restricted Project

Oct 18 2021

Sockke added a comment to D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg.

Hi, Could anyone please review this diff? @whisperity, @aaron.ballman

Oct 18 2021, 5:26 AM · Restricted Project

Oct 13 2021

Sockke added a comment to D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg.

Kindly ping.

Oct 13 2021, 9:00 AM · Restricted Project
Sockke added a comment to D110326: [LegacyPassManager] Demangling function name in ftime-trace output..

How about adding an option to determine whether to demangle the function name or not?

Making this a non-default option sounds good.

Oct 13 2021, 8:59 AM · Restricted Project
Sockke added a comment to D110326: [LegacyPassManager] Demangling function name in ftime-trace output..
Oct 13 2021, 8:58 AM · Restricted Project
Sockke added a comment to D111625: [clang-tidy] bugprone-argument-comment: SourceLocation valid judgment avoid emitting coredump in isInSystemHeader.

LGTM, thank you! Do you need me to commit on your behalf? I'm happy to do so, but given the number of quality submissions you've had, I'm wondering if you'd like to obtain commit access of your own? (https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access has the details of what that entails.)

Oct 13 2021, 8:54 AM · Restricted Project
Sockke updated the diff for D111625: [clang-tidy] bugprone-argument-comment: SourceLocation valid judgment avoid emitting coredump in isInSystemHeader.

Update!

Oct 13 2021, 1:18 AM · Restricted Project

Oct 12 2021

Sockke requested review of D111625: [clang-tidy] bugprone-argument-comment: SourceLocation valid judgment avoid emitting coredump in isInSystemHeader.
Oct 12 2021, 2:41 AM · Restricted Project

Oct 8 2021

Sockke updated the diff for D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg.

Sorry for the delayed reply because of National Day. I have updated. @whisperity

Oct 8 2021, 4:50 AM · Restricted Project

Sep 29 2021

Sockke added a comment to D110326: [LegacyPassManager] Demangling function name in ftime-trace output..

Please can you explain what problem you are trying to solve, on the higher level?

Sep 29 2021, 6:05 AM · Restricted Project
Sockke added a comment to D110326: [LegacyPassManager] Demangling function name in ftime-trace output..

Thanks, sorry for the delayed reply.
Yes, fair point. How about adding an option to determine whether to demangle the function name or not?

Sep 29 2021, 3:57 AM · Restricted Project

Sep 24 2021

Sockke added a comment to D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init.

LGTM!

Sep 24 2021, 7:55 AM · Restricted Project
Sockke added a comment to D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init.
Sep 24 2021, 7:54 AM · Restricted Project

Sep 23 2021

Sockke requested review of D110326: [LegacyPassManager] Demangling function name in ftime-trace output..
Sep 23 2021, 6:04 AM · Restricted Project
Sockke added a comment to D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg.

Hi, Could you please take some time to review this diff again? @whisperity

Sep 23 2021, 6:02 AM · Restricted Project
Sockke added inline comments to D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init.
Sep 23 2021, 5:09 AM · Restricted Project
Sockke updated the diff for D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init.

Update!

Sep 23 2021, 5:08 AM · Restricted Project

Sep 22 2021

Sockke added a comment to D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init.

Hi, Could you please take some time to review this diff again? @aaron.ballman

Sep 22 2021, 8:10 AM · Restricted Project

Sep 13 2021

Sockke added a comment to D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg.

kindly ping.

Sep 13 2021, 6:08 AM · Restricted Project
Sockke added inline comments to D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init.
Sep 13 2021, 1:26 AM · Restricted Project

Sep 2 2021

Sockke added a comment to D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init.

Hi, Could anyone please review this diff?

Sep 2 2021, 8:41 AM · Restricted Project

Aug 31 2021

Sockke added a comment to D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg.

Thanks for your review, I greatly appreciate it. @whisperity
There is no wrong case in the original test file, which is why we did not catch the bug in the test suite. From this, I added some new cases.
I tested the functions with multi-parameters, there is no problem, I will add them to the test file.

Aug 31 2021, 5:38 AM · Restricted Project

Aug 24 2021

Sockke added a comment to D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg.

Which do you prefer? @Quuxplusone

Aug 24 2021, 8:23 AM · Restricted Project
Sockke added a comment to D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init.

What do you think? @aaron.ballman @bkramer

Aug 24 2021, 8:20 AM · Restricted Project

Aug 23 2021

Sockke added a comment to D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init.

Any thoughts? : )

Aug 23 2021, 6:19 AM · Restricted Project

Aug 20 2021

Sockke added a comment to D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg.

Any thoughts? : )

Aug 20 2021, 6:00 AM · Restricted Project
Sockke added a comment to D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg.
Aug 20 2021, 5:59 AM · Restricted Project
Sockke added a comment to D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init.

Any thoughts? : )

Aug 20 2021, 5:56 AM · Restricted Project
Sockke added a comment to D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init.
Aug 20 2021, 5:54 AM · Restricted Project