The annotation about ignoringImpCasts is wrong, which will cause misunderstanding. Fix it.
gehry
ByteDance
Differential D105973
[ASTMatchers] NFC: Fix the annotation. Sockke on Jul 14 2021, 5:35 AM. Authored by
Details
The annotation about ignoringImpCasts is wrong, which will cause misunderstanding. Fix it. gehry
Diff Detail
Unit Tests Event TimelineComment Actions The change looks good to me, but you need to regenerate the documentation manually. You can do so by running clang/docs/tools/dump_ast_matchers.py. Comment Actions Thanks for your review! I have run clang/docs/tools/dump_ast_matchers.py to regenerate the documentation. Comment Actions LGTM, thank you for the fix! Do you need me to commit it on your behalf? If so, what name and email address would you like me to use for patch attribution? Comment Actions I would appreciate it if you could submit it on my behalf. Thanks a lot! Name: liuke Comment Actions Thank you for the patch! I've commit on your behalf in 034b94bb7161c64234e4ec35bf49428c3a1f8f0a. |