This is an archive of the discontinued LLVM Phabricator instance.

[NFC][AMDGPU] autogenerate kill-infinite-loop.ll checks
AbandonedPublic

Authored by ruiling on Jul 7 2021, 11:30 PM.

Details

Reviewers
None
Summary

This would help us to track the assembly changes to these tests.

[AMDGPU] Don't handle export done in unify exit nodes

This patch aims to revert the changes introduced by D70781 D71192 D76364

D70781 was introduced to fix hardware hang where we do not insert exp-
null-done for a kill inside infinit loop. At that time we have not added
exp-null-done for kill early termination, but I believe as for now, we will
always add the exp-null-done for early termination case in LaterBranchLowering.

D71192 was introduced to handle the only_kill case, which is also been
handled by the kill early termination work.

D76364 was used to fix a regression by D71192, where we cleared the done
bit of the export in the existing program and not let the normal return
block branching to the new unified return block.

With this change, we just trust frontends have setup exp-done correctly
which is true for all existing frontends. The backend only inserts
exp-null-done for the kill cases which is handled in SILateBranchLowering.cpp.

Diff Detail

Event Timeline

ruiling created this revision.Jul 7 2021, 11:30 PM
ruiling requested review of this revision.Jul 7 2021, 11:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2021, 11:30 PM
ruiling abandoned this revision.Jul 7 2021, 11:31 PM

uploaded accidentally