This is an archive of the discontinued LLVM Phabricator instance.

[COFF] [CodeView] Add a few new enum values
ClosedPublic

Authored by mstorsjo on Jul 6 2021, 2:28 PM.

Details

Summary

These are undocumented, but are visible in the SDK headers since some
versions ago.

Diff Detail

Event Timeline

mstorsjo created this revision.Jul 6 2021, 2:28 PM
mstorsjo requested review of this revision.Jul 6 2021, 2:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 6 2021, 2:28 PM
smeenai accepted this revision.Jul 6 2021, 2:57 PM

LGTM

Would we want tests for the cpp file changes?

This revision is now accepted and ready to land.Jul 6 2021, 2:57 PM

Would we want tests for the cpp file changes?

Hmm, as long as it just adds constants without any more specific logic I kinda wouldn't bother (I'm sure we don't have test coverage for all enum values that can be printed anyway)...

This revision was automatically updated to reflect the committed changes.