This is an archive of the discontinued LLVM Phabricator instance.

Differential D105489

[compiler-rt] [test] Fix asan symbolize tests on py3.10
ClosedPublic

Authored by mgorny on Jul 6 2021, 9:13 AM.

Details

Reviewers
delcypher
kcc
Commits
rG2d68bb1765f9: [compiler-rt] [test] Fix asan symbolize tests on py3.10
Summary

Update the asan_symbolize_script for changes in argparse output
in Python 3.10. The parser output 'options' instead of 'optional
arguments'.

Diff Detail

Event Timeline

mgorny created this revision.Jul 6 2021, 9:13 AM
Herald added a subscriber: dberris. · View Herald TranscriptJul 6 2021, 9:13 AM
mgorny requested review of this revision.Jul 6 2021, 9:13 AM
mgorny added a reviewer: kcc.
Harbormaster completed remote builds in B112639: Diff 356750.Jul 6 2021, 9:42 AM
delcypher accepted this revision.Jul 6 2021, 10:54 AM

LGTM

This revision is now accepted and ready to land.Jul 6 2021, 10:54 AM
Closed by commit rG2d68bb1765f9: [compiler-rt] [test] Fix asan symbolize tests on py3.10 (authored by mgorny). · Explain WhyJul 6 2021, 11:41 AM
This revision was automatically updated to reflect the committed changes.
mgorny added a commit: rG2d68bb1765f9: [compiler-rt] [test] Fix asan symbolize tests on py3.10.
Herald added a project: Restricted Project. · View Herald TranscriptJul 6 2021, 11:41 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript

Revision Contents

PathSize
compiler-rt/
test/
asan/
TestCases/
Posix/
asan_symbolize_script/
2 lines
2 lines

Diff 356750

compiler-rt/test/asan/TestCases/Posix/asan_symbolize_script/logging_options_in_help.cpp

// RUN: %asan_symbolize --help > %t_help_output.txt // RUN: %asan_symbolize --help > %t_help_output.txt
// RUN: FileCheck %s -input-file=%t_help_output.txt // RUN: FileCheck %s -input-file=%t_help_output.txt
// CHECK: optional arguments: // CHECK: option{{al arguments|s}}:
// CHECK: --log-dest // CHECK: --log-dest
// CHECK: --log-level // CHECK: --log-level

compiler-rt/test/asan/TestCases/Posix/asan_symbolize_script/plugin_no_op_help_output.cpp

// Check help output. // Check help output.
// RUN: %asan_symbolize --log-level info --plugins %S/plugin_no_op.py --help 2>&1 | FileCheck %s // RUN: %asan_symbolize --log-level info --plugins %S/plugin_no_op.py --help 2>&1 | FileCheck %s
// CHECK: Registering plugin NoOpPlugin // CHECK: Registering plugin NoOpPlugin
// CHECK: Adding --unlikely-option-name-XXX option // CHECK: Adding --unlikely-option-name-XXX option
// CHECK: optional arguments: // CHECK: option{{al arguments|s}}:
// CHECK: --unlikely-option-name-XXX // CHECK: --unlikely-option-name-XXX