This is an archive of the discontinued LLVM Phabricator instance.

Differential D105452

[lld][MachO] Code cleanup
ClosedPublic

Authored by alexander-shaposhnikov on Jul 5 2021, 7:14 PM.

Details

Reviewers
thakis
int3
gkm
Group Reviewers
Restricted Project
Commits
rGd21772fa21de: [lld][MachO] Code cleanup
Summary

Make use of ArgList::getLastArgValue. NFC.

Test plan: make check-lld-macho

Diff Detail

Event Timeline

alexander-shaposhnikov created this revision.Jul 5 2021, 7:14 PM
Herald added a reviewer: int3. · View Herald TranscriptJul 5 2021, 7:14 PM
Herald added a reviewer: gkm. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
alexander-shaposhnikov requested review of this revision.Jul 5 2021, 7:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 5 2021, 7:14 PM
Harbormaster completed remote builds in B112510: Diff 356587.Jul 5 2021, 7:42 PM
int3 accepted this revision.Jul 5 2021, 8:51 PM

Thanks!

This revision is now accepted and ready to land.Jul 5 2021, 8:51 PM
thakis accepted this revision.Jul 8 2021, 11:33 AM

D'oh, thanks :)

thakis added a comment.Jul 13 2021, 9:42 AM

…want to land this?

Closed by commit rGd21772fa21de: [lld][MachO] Code cleanup (authored by alexander-shaposhnikov). · Explain WhyJul 14 2021, 4:33 AM
This revision was automatically updated to reflect the committed changes.
alexander-shaposhnikov added a commit: rGd21772fa21de: [lld][MachO] Code cleanup.

Revision Contents

PathSize
lld/
MachO/
6 lines

Diff 358560

lld/MachO/Driver.cpp

Show First 20 Lines • Show All 1,136 Lines • ▼ Show 20 Lines config->explicitUndefineds.push_back(symtab->addUndefined(
arg->getValue(), /*file=*/nullptr, /*isWeakRef=*/false)); arg->getValue(), /*file=*/nullptr, /*isWeakRef=*/false));
} }
for (const Arg *arg : args.filtered(OPT_U)) for (const Arg *arg : args.filtered(OPT_U))
symtab->addDynamicLookup(arg->getValue()); symtab->addDynamicLookup(arg->getValue());
config->mapFile = args.getLastArgValue(OPT_map); config->mapFile = args.getLastArgValue(OPT_map);
config->outputFile = args.getLastArgValue(OPT_o, "a.out"); config->outputFile = args.getLastArgValue(OPT_o, "a.out");
if (const Arg *arg = args.getLastArg(OPT_final_output)) config->finalOutput =
config->finalOutput = arg->getValue(); args.getLastArgValue(OPT_final_output, config->outputFile);
else
config->finalOutput = config->outputFile;
config->astPaths = args.getAllArgValues(OPT_add_ast_path); config->astPaths = args.getAllArgValues(OPT_add_ast_path);
config->headerPad = args::getHex(args, OPT_headerpad, /*Default=*/32); config->headerPad = args::getHex(args, OPT_headerpad, /*Default=*/32);
config->headerPadMaxInstallNames = config->headerPadMaxInstallNames =
args.hasArg(OPT_headerpad_max_install_names); args.hasArg(OPT_headerpad_max_install_names);
config->printDylibSearch = config->printDylibSearch =
args.hasArg(OPT_print_dylib_search) || getenv("RC_TRACE_DYLIB_SEARCHING"); args.hasArg(OPT_print_dylib_search) || getenv("RC_TRACE_DYLIB_SEARCHING");
config->printEachFile = args.hasArg(OPT_t); config->printEachFile = args.hasArg(OPT_t);
config->printWhyLoad = args.hasArg(OPT_why_load); config->printWhyLoad = args.hasArg(OPT_why_load);
▲ Show 20 Lines • Show All 320 Lines • Show Last 20 Lines