This is an archive of the discontinued LLVM Phabricator instance.

[docs] Fix linking issues in LibASTMatchers tutorial
ClosedPublic

Authored by jubnzv on Jul 4 2021, 11:18 AM.

Details

Summary

Update CMakeLists.txt in the tutorial to reflect the latest changes in LLVM.
The demo projects cannot be linked without added libraries.

Diff Detail

Event Timeline

jubnzv requested review of this revision.Jul 4 2021, 11:18 AM
jubnzv created this revision.
xgupta accepted this revision.Jul 4 2021, 11:06 PM
xgupta added a subscriber: xgupta.

Thanks for the patch @jubnzv!
Except that one nit changes look good to me. Just a few months ago I also face a similar issue with RAVFrontendAction.rst during Shared build and commit a patch rG6ee1f64a2e828d27a6c20839232b3ac828367123.

clang/docs/LibASTMatchersTutorial.rst
110

You should list these or preferably all target_link_librarie in alphabetical order for example see: https://github.com/llvm/llvm-project/blob/main/clang/lib/Tooling/CMakeLists.txt#L125.

This revision is now accepted and ready to land.Jul 4 2021, 11:06 PM
jubnzv updated this revision to Diff 356452.Jul 5 2021, 2:08 AM

Thanks! I've sorted the libraries.

This revision was landed with ongoing or failed builds.Jul 5 2021, 2:12 AM
This revision was automatically updated to reflect the committed changes.
jubnzv marked an inline comment as done.
Herald added a project: Restricted Project. · View Herald TranscriptJul 5 2021, 2:12 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript