Page MenuHomePhabricator

jubnzv (Georgy Komarov)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 13 2020, 7:40 PM (46 w, 5 d)

Recent Activity

Yesterday

jubnzv added inline comments to D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list.
Thu, May 6, 12:13 AM · Restricted Project

Tue, May 4

jubnzv committed rGc2e9baf2e8da: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with… (authored by jubnzv).
[clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with…
Tue, May 4, 3:49 AM
jubnzv closed D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list.
Tue, May 4, 3:49 AM · Restricted Project

Sat, May 1

jubnzv updated the diff for D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list.
Sat, May 1, 8:54 AM · Restricted Project

Wed, Apr 28

jubnzv updated the diff for D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list.
Wed, Apr 28, 12:02 AM · Restricted Project

Tue, Apr 27

jubnzv added a comment to D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list.

Thanks, I updated my patch and now CI is happy.
I also found a few additional cases that can lead to false positives on the platforms which implements __builtin_va_list as void * or char *, and added additional checks for this.

Tue, Apr 27, 3:22 AM · Restricted Project
jubnzv updated the diff for D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list.
Tue, Apr 27, 1:45 AM · Restricted Project
jubnzv updated the diff for D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list.
Tue, Apr 27, 12:25 AM · Restricted Project

Mon, Apr 26

jubnzv updated the diff for D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list.
Mon, Apr 26, 10:03 PM · Restricted Project

Sun, Apr 25

jubnzv requested review of D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list.
Sun, Apr 25, 9:10 AM · Restricted Project

Thu, Apr 22

jubnzv committed rG9a930aa5bd2f: [clang-tidy] Avoid bugprone-macro-parentheses warnings after goto argument (authored by jubnzv).
[clang-tidy] Avoid bugprone-macro-parentheses warnings after goto argument
Thu, Apr 22, 12:17 AM
jubnzv closed D99924: [clang-tidy] Avoid bugprone-macro-parentheses warnings after goto argument.
Thu, Apr 22, 12:16 AM · Restricted Project

Sat, Apr 17

jubnzv added a comment to D99924: [clang-tidy] Avoid bugprone-macro-parentheses warnings after goto argument.

Ping. Could somebody review this, please?

Sat, Apr 17, 9:40 AM · Restricted Project

Apr 6 2021

jubnzv updated the diff for D99924: [clang-tidy] Avoid bugprone-macro-parentheses warnings after goto argument.
Apr 6 2021, 9:02 AM · Restricted Project
jubnzv updated the diff for D99924: [clang-tidy] Avoid bugprone-macro-parentheses warnings after goto argument.
Apr 6 2021, 12:26 AM · Restricted Project

Apr 5 2021

jubnzv requested review of D99924: [clang-tidy] Avoid bugprone-macro-parentheses warnings after goto argument.
Apr 5 2021, 10:32 PM · Restricted Project

Jul 4 2020

jubnzv committed rGafd81a637dfc: [llvm-objcopy] Fix crash when removing symbol table at same time as adding a… (authored by jubnzv).
[llvm-objcopy] Fix crash when removing symbol table at same time as adding a…
Jul 4 2020, 7:28 PM
jubnzv closed D82935: [llvm-objcopy] Fix crash when removing symbol table at same time as adding a symbol.
Jul 4 2020, 7:26 PM · Restricted Project

Jul 3 2020

jubnzv updated the diff for D82935: [llvm-objcopy] Fix crash when removing symbol table at same time as adding a symbol.
Jul 3 2020, 5:53 AM · Restricted Project
jubnzv added inline comments to D82935: [llvm-objcopy] Fix crash when removing symbol table at same time as adding a symbol.
Jul 3 2020, 5:53 AM · Restricted Project
jubnzv updated the diff for D82935: [llvm-objcopy] Fix crash when removing symbol table at same time as adding a symbol.
Jul 3 2020, 5:21 AM · Restricted Project
jubnzv added inline comments to D82935: [llvm-objcopy] Fix crash when removing symbol table at same time as adding a symbol.
Jul 3 2020, 4:16 AM · Restricted Project
jubnzv updated the diff for D82935: [llvm-objcopy] Fix crash when removing symbol table at same time as adding a symbol.
Jul 3 2020, 4:16 AM · Restricted Project
jubnzv updated the diff for D82935: [llvm-objcopy] Fix crash when removing symbol table at same time as adding a symbol.

Thanks. Fixed.

Jul 3 2020, 2:39 AM · Restricted Project

Jul 2 2020

jubnzv updated the diff for D82935: [llvm-objcopy] Fix crash when removing symbol table at same time as adding a symbol.

Actually, does the createSymbolTable function even need to be a member of ELFBuilder? My main objection is the use of the builder a long time after initialization of the Object (along with the complexity of calling it due to the template), but I don't think you actually need it.

Jul 2 2020, 10:39 PM · Restricted Project

Jul 1 2020

jubnzv updated the diff for D82935: [llvm-objcopy] Fix crash when removing symbol table at same time as adding a symbol.

Thanks for the comment @jhenderson. I updated the test.

Jul 1 2020, 8:05 AM · Restricted Project
Herald added a reviewer for D82935: [llvm-objcopy] Fix crash when removing symbol table at same time as adding a symbol: alexshap.
Jul 1 2020, 1:02 AM · Restricted Project

Jun 29 2020

jubnzv added a comment to D82274: [llvm-objcopy] Emit error if removing symbol table referenced by SHT_GROUP section.

@jhenderson thanks for helping me. I'll remember these tips for next time.

Could you please commit this for me?

Can do. What do you want for your Git author name and email?

Jun 29 2020, 1:34 AM · Restricted Project

Jun 26 2020

jubnzv accepted D82274: [llvm-objcopy] Emit error if removing symbol table referenced by SHT_GROUP section.
Jun 26 2020, 9:20 PM · Restricted Project
jubnzv updated the diff for D82274: [llvm-objcopy] Emit error if removing symbol table referenced by SHT_GROUP section.
Jun 26 2020, 9:20 PM · Restricted Project
jubnzv accepted D82274: [llvm-objcopy] Emit error if removing symbol table referenced by SHT_GROUP section.

@jhenderson thanks for helping me. I'll remember these tips for next time.

Jun 26 2020, 8:01 PM · Restricted Project

Jun 25 2020

jubnzv updated the diff for D82274: [llvm-objcopy] Emit error if removing symbol table referenced by SHT_GROUP section.

I agree, this makes it cleaner.

Jun 25 2020, 2:30 AM · Restricted Project

Jun 24 2020

jubnzv updated the diff for D82274: [llvm-objcopy] Emit error if removing symbol table referenced by SHT_GROUP section.

@jhenderson thanks for the tip. I added some checks for sh_link field and updated the test.

Jun 24 2020, 9:42 AM · Restricted Project

Jun 23 2020

jubnzv added inline comments to D82274: [llvm-objcopy] Emit error if removing symbol table referenced by SHT_GROUP section.
Jun 23 2020, 7:59 PM · Restricted Project
jubnzv added a comment to D82274: [llvm-objcopy] Emit error if removing symbol table referenced by SHT_GROUP section.

@jhenderson thank you very much for your thoughtful review!

Jun 23 2020, 7:26 PM · Restricted Project
jubnzv updated the diff for D82274: [llvm-objcopy] Emit error if removing symbol table referenced by SHT_GROUP section.
Jun 23 2020, 7:26 PM · Restricted Project

Jun 21 2020

Herald added a reviewer for D82274: [llvm-objcopy] Emit error if removing symbol table referenced by SHT_GROUP section: alexshap.
Jun 21 2020, 1:33 AM · Restricted Project