- User Since
- Jun 13 2020, 7:40 PM (46 w, 5 d)
Tue, May 4
Sat, May 1
Wed, Apr 28
Tue, Apr 27
Thanks, I updated my patch and now CI is happy.
I also found a few additional cases that can lead to false positives on the platforms which implements __builtin_va_list as void * or char *, and added additional checks for this.
Mon, Apr 26
Sun, Apr 25
Thu, Apr 22
Sat, Apr 17
Ping. Could somebody review this, please?
Apr 6 2021
Apr 5 2021
Jul 4 2020
Jul 3 2020
Jul 2 2020
Actually, does the createSymbolTable function even need to be a member of ELFBuilder? My main objection is the use of the builder a long time after initialization of the Object (along with the complexity of calling it due to the template), but I don't think you actually need it.
Jul 1 2020
Thanks for the comment @jhenderson. I updated the test.
Jun 29 2020
Jun 26 2020
@jhenderson thanks for helping me. I'll remember these tips for next time.
Jun 25 2020
I agree, this makes it cleaner.
Jun 24 2020
@jhenderson thanks for the tip. I added some checks for sh_link field and updated the test.
Jun 23 2020
@jhenderson thank you very much for your thoughtful review!