[WIP][llvm-size] Switch command line parsing from llvm::cl to OptTable

[xgupta]

Summary

This is similar to D104889, but for llvm-size. Please refer to
https://lists.llvm.org/pipermail/llvm-dev/2021-July/151622.html for some
discussion around these changes.

llvm/docs/CommandGuide/llvm-size.rst

Segment : 48
              Section (__DATA, __data): 32
              total 48
      total 48
 
 .. option:: --help, -h
 
  Display a summary of command line options.
 
-.. option:: --help-list
-
- Display an uncategorized summary of command line options.
-
 .. option:: -m
 
  Equivalent to :option:`--format` with a value of ``darwin``.
 
 .. option:: -o
 
  Equivalent to :option:`--radix` with a value of ``8``.
 

llvm/tools/llvm-size/CMakeLists.txt

 set(LLVM_LINK_COMPONENTS
   Object
+  Option
   Support
   )
 
+set(LLVM_TARGET_DEFINITIONS Opts.td)
+tablegen(LLVM Opts.inc -gen-opt-parser-defs)
+add_public_tablegen_target(StringsOptsTableGen)
+
 add_llvm_tool(llvm-size
   llvm-size.cpp
+  DEPENDS
+  SizeOptsTableGen
   )
 
 if(LLVM_INSTALL_BINUTILS_SYMLINKS)
   add_llvm_tool_symlink(size llvm-size)
 endif()

llvm/tools/llvm-size/Opts.td

+include "llvm/Option/OptParser.td"
+
+class F<string letter, string help> : Flag<["-"], letter>, HelpText<help>;
+class FF<string name, string help> : Flag<["--"], name>, HelpText<help>;
+
+multiclass Eq<string name, string help> {
+  def NAME #_EQ : Joined<["--"], name #"=">,
+                  HelpText<help>;
+  def : Separate<["--"], name>, Alias<!cast<Joined>(NAME #_EQ)>;
+}
+
+defm arch : Eq<"arch", "architecture(s) from a Mach-O file to dump">;
+defm format : Eq<"format", "Specify output format">;
+defm radix : Eq<"radix", "Print size in specified radix">;
+
+def common : FF<"common", "Print common symbols in the ELF file.  When using Berkeley format, this is added to bss.">;
+def totals : FF<"totals", "Print totals of all objects - Berkeley format only">;
+def help : FF<"help", "Display available options (--help-hidden for more)">;
+def help_hidden : FF<"help-hidden">;
+def version : FF<"version", "Display the version of this program">;
+
+def l : F<"l", "When format is darwin, use long format to include addresses and offsets.">;
+
+def : F<"t", "Alias for --totals">, Alias<totals>;

llvm/tools/llvm-size/llvm-size.cpp

 //===-- llvm-size.cpp - Print the size of each object section ---*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
 // This program is a utility that works like traditional Unix "size",
 // that is, it prints out the size of each section, and the total size of all
 // sections.
 //
 //===----------------------------------------------------------------------===//
 
+#include "Opts.inc"
 #include "llvm/ADT/APInt.h"
 #include "llvm/Object/Archive.h"
 #include "llvm/Object/ELFObjectFile.h"
 #include "llvm/Object/MachO.h"
 #include "llvm/Object/MachOUniversal.h"
 #include "llvm/Object/ObjectFile.h"
+#include "llvm/Option/Arg.h"
+#include "llvm/Option/ArgList.h"
+#include "llvm/Option/Option.h"
 #include "llvm/Support/Casting.h"
 #include "llvm/Support/CommandLine.h"
 #include "llvm/Support/FileSystem.h"
 #include "llvm/Support/Format.h"
 #include "llvm/Support/InitLLVM.h"
 #include "llvm/Support/MemoryBuffer.h"
 #include "llvm/Support/WithColor.h"
 #include "llvm/Support/raw_ostream.h"
 #include <algorithm>
 #include <string>
 #include <system_error>
 
 using namespace llvm;
 using namespace object;
 
+namespace {
+enum ID {
+  OPT_INVALID = 0, // This is not an option ID.
+#define OPTION(PREFIX, NAME, ID, KIND, GROUP, ALIAS, ALIASARGS, FLAGS, PARAM,  \
+               HELPTEXT, METAVAR, VALUES)                                      \
+  OPT_##ID,
+#include "Opts.inc"
+#undef OPTION
+};
+
+#define PREFIX(NAME, VALUE) const char *const NAME[] = VALUE;
+#include "Opts.inc"
+#undef PREFIX
+
+static const opt::OptTable::Info InfoTable[] = {
+#define OPTION(PREFIX, NAME, ID, KIND, GROUP, ALIAS, ALIASARGS, FLAGS, PARAM,  \
+               HELPTEXT, METAVAR, VALUES)                                      \
+  {                                                                            \
+      PREFIX,      NAME,      HELPTEXT,                                        \
+      METAVAR,     OPT_##ID,  opt::Option::KIND##Class,                        \
+      PARAM,       FLAGS,     OPT_##GROUP,                                     \
+      OPT_##ALIAS, ALIASARGS, VALUES},
+#include "Opts.inc"
+#undef OPTION
+};
+
+class SizeOptTable : public opt::OptTable {
+public:
+  SizeOptTable() : OptTable(InfoTable) { setGroupedShortOptions(true); }
+};
+} // namespace
+
 cl::OptionCategory SizeCat("llvm-size Options");
 
 enum OutputFormatTy { berkeley, sysv, darwin };
 static cl::opt<OutputFormatTy>
     OutputFormat("format", cl::desc("Specify output format"),
                  cl::values(clEnumVal(sysv, "System V format"),
                             clEnumVal(berkeley, "Berkeley format"),
                             clEnumVal(darwin, "Darwin -m format")),

 
 static cl::opt<RadixTy> RadixShort(
     cl::desc("Print size in radix:"),
     cl::values(clEnumValN(octal, "o", "Print size in octal"),
                clEnumValN(decimal, "d", "Print size in decimal"),
                clEnumValN(hexadecimal, "x", "Print size in hexadecimal")),
     cl::init(decimal), cl::cat(SizeCat));
 
-static cl::opt<bool>
-    TotalSizes("totals",
-               cl::desc("Print totals of all objects - Berkeley format only"),
-               cl::init(false), cl::cat(SizeCat));
-
-static cl::alias TotalSizesShort("t", cl::desc("Short for --totals"),
-                                 cl::aliasopt(TotalSizes));
-
 static cl::list<std::string>
     InputFilenames(cl::Positional, cl::desc("<input files>"), cl::ZeroOrMore);
 
 static cl::extrahelp
     HelpResponse("\nPass @FILE as argument to read options from FILE.\n");
 
 static bool HadError = false;