This is an archive of the discontinued LLVM Phabricator instance.

Revert "[libomptarget] [amdgpu] Fix default setting of max flat workgroup size"
ClosedPublic

Authored by dhruvachak on Jun 30 2021, 5:11 PM.

Details

Summary

This reverts commit 2240b41ee4f30fe938975677a0a5a2c5c26d271b.
A value of 0 for KernDescVal WG_Size implies it is unknown, so it should be
set to the default. The above change was made without this assumption.

Diff Detail

Event Timeline

dhruvachak created this revision.Jun 30 2021, 5:11 PM
dhruvachak requested review of this revision.Jun 30 2021, 5:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 30 2021, 5:11 PM
JonChesterfield accepted this revision.Jun 30 2021, 5:12 PM

git revert is also good. Thanks

This revision is now accepted and ready to land.Jun 30 2021, 5:12 PM
This revision was landed with ongoing or failed builds.Jun 30 2021, 5:15 PM
This revision was automatically updated to reflect the committed changes.