This is an archive of the discontinued LLVM Phabricator instance.

[libc] Add minimal Windows config
ClosedPublic

Authored by caitlyncano on Jun 30 2021, 2:32 PM.

Details

Summary

A README file with procedure for building/testing LLVM libc on Windows
has also been added.

Diff Detail

Event Timeline

caitlyncano created this revision.Jun 30 2021, 2:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 30 2021, 2:32 PM
caitlyncano requested review of this revision.Jun 30 2021, 2:32 PM

There are a few warnings that will arise in CMake and build steps that will be resolved in followup patches.

aeubanks added inline comments.Jun 30 2021, 2:52 PM
libc/config/windows/README.md
34

I don't think we need to tell people how to build their own clang, we can tell them to get a recent clang somehow, either by downloading from https://releases.llvm.org/download.html or by building themselves (point to building clang documentation).

libc/config/windows/entrypoints.txt
19–20

do you know what character is on this newline? there's an orange exclamation mark that I haven't seen before that probably shouldn't be there. Maybe a \r?

[libc] Updating Windows config

Removing flagged whitespace from config file and outsourcing Clang build
instructions in README.md to the official documentation online.

caitlyncano marked 2 inline comments as done.Jul 1 2021, 9:20 AM

mostly lgtm, just a couple nits

libc/config/windows/README.md
58

maybe it's good to explicitly state that libc needs to use the recently downloaded/built clang

libc/config/windows/entrypoints.txt
19–20

now the character has moved a couple lines above

[libc] Editing README.md

Specifying that Clang compilation is required to build LLVM libc in README.md
and fixing whitespace issue in entrypoints.txt

caitlyncano marked 2 inline comments as done.Jul 1 2021, 11:59 AM
aeubanks accepted this revision.Jul 1 2021, 12:26 PM

lgtm, thanks!

This revision is now accepted and ready to land.Jul 1 2021, 12:26 PM
sivachandra accepted this revision.Jul 1 2021, 1:29 PM
This revision was automatically updated to reflect the committed changes.