This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Don't use -Bsymbolic-functions for MinGW targets
ClosedPublic

Authored by mstorsjo on Jun 29 2021, 1:51 PM.

Details

Summary

This is an ELF specific option which isn't supported for Windows/MinGW
targets, even if the MinGW linker otherwise uses a ld.bfd like linker
interface.

In llvm-shlib, there's already a separate if statement for

if (NOT LLVM_LINKER_IS_SOLARISLD AND NOT MINGW)

but I don't know if the solaris linker supports -Bsymbolic-functions
or not.

Diff Detail

Event Timeline

mstorsjo created this revision.Jun 29 2021, 1:51 PM
mstorsjo requested review of this revision.Jun 29 2021, 1:51 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 29 2021, 1:51 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
MaskRay accepted this revision.Jun 29 2021, 2:20 PM

but I don't know if the solaris linker supports -Bsymbolic-functions or not.

According to a Solaris "man pages section 1: User Commands", -Bsymbolic-functions is supported.

This revision is now accepted and ready to land.Jun 29 2021, 2:20 PM
This revision was automatically updated to reflect the committed changes.