This is an archive of the discontinued LLVM Phabricator instance.

Fail gracefully if no inlining model is available to download.
ClosedPublic

Authored by jacobhegna on Jun 23 2021, 6:18 PM.

Diff Detail

Event Timeline

jacobhegna created this revision.Jun 23 2021, 6:18 PM
jacobhegna requested review of this revision.Jun 23 2021, 6:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 23 2021, 6:18 PM
mtrofin added inline comments.Jun 23 2021, 8:00 PM
llvm/lib/Analysis/CMakeLists.txt
17 ↗(On Diff #354127)

should this be handled in TensorflowCompile.cmake? Likely common behavior.

Move the relevant code to TensorflowCompile.cmake.

When removing a model, the default url should be set to the string literal
"none".

We cannot simply set it to "", as cmake will then think that the call to
tf_find_and_compile is missing and argument.

Change "none" -> "TO_BE_UPDATED".

mtrofin accepted this revision.Jun 29 2021, 12:47 PM
This revision is now accepted and ready to land.Jun 29 2021, 12:47 PM