This is an archive of the discontinued LLVM Phabricator instance.

[AIX] Use less than or equal to for some alignment tests on AIX
ClosedPublic

Authored by ZarkoCA on Jun 23 2021, 7:59 AM.

Details

Summary

On AIX the alignment implementation has the storage aligned to the
preferred alignment instead of the alignment of a type. Macro guard
these tests for AIX and have them pass when the "reference alignment" is
less than or equal to the alignment observed. In other words, the
alignment applied is at least as strict as the required alignment.

Diff Detail

Event Timeline

ZarkoCA requested review of this revision.Jun 23 2021, 7:59 AM
ZarkoCA created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJun 23 2021, 7:59 AM
hubert.reinterpretcast edited the summary of this revision. (Show Details)

LGTM, but please note the adjustment to the description.

This revision is now accepted and ready to land.Jun 25 2021, 7:48 PM
This revision was landed with ongoing or failed builds.Jun 28 2021, 7:32 AM
This revision was automatically updated to reflect the committed changes.