This is an archive of the discontinued LLVM Phabricator instance.

[LangRef] add note to warn-frame-size about ODR
ClosedPublic

Authored by nickdesaulniers on Jun 22 2021, 12:10 PM.

Diff Detail

Event Timeline

nickdesaulniers requested review of this revision.Jun 22 2021, 12:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 22 2021, 12:10 PM
dblaikie added inline comments.Jun 22 2021, 12:52 PM
llvm/docs/LangRef.rst
2055–2057

That's probably not correct/feasible - ODR violations are "invalid, NDR" ie: pretty close to UB. Actually it'd be very easy for us to detect this (& we did in the old module metadata version) and reject it - so I think we've demonstrated that this is acceptable, but that we make no guarantees about which threshold will be respected.

C++-ish language would be to say "it's unspecified which threshold will be used when duplicate definitions are linked together"

  • update comment
nickdesaulniers marked an inline comment as done.Jun 23 2021, 10:43 AM
dblaikie accepted this revision.Jun 23 2021, 12:19 PM

Sounds alright

This revision is now accepted and ready to land.Jun 23 2021, 12:19 PM
This revision was automatically updated to reflect the committed changes.