Details
Details
- Reviewers
dblaikie - Commits
- rG24d48d45cc30: [LangRef] add note to warn-frame-size about ODR
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/docs/LangRef.rst | ||
---|---|---|
2055–2057 | That's probably not correct/feasible - ODR violations are "invalid, NDR" ie: pretty close to UB. Actually it'd be very easy for us to detect this (& we did in the old module metadata version) and reject it - so I think we've demonstrated that this is acceptable, but that we make no guarantees about which threshold will be respected. C++-ish language would be to say "it's unspecified which threshold will be used when duplicate definitions are linked together" |
That's probably not correct/feasible - ODR violations are "invalid, NDR" ie: pretty close to UB. Actually it'd be very easy for us to detect this (& we did in the old module metadata version) and reject it - so I think we've demonstrated that this is acceptable, but that we make no guarantees about which threshold will be respected.
C++-ish language would be to say "it's unspecified which threshold will be used when duplicate definitions are linked together"