This is an archive of the discontinued LLVM Phabricator instance.

[llvm-profdata] Allow omission of -o for --text output
ClosedPublic

Authored by MaskRay on Jun 19 2021, 4:13 PM.

Details

Summary

This makes it more convenient to get a text format profile.

Add an error for printing non-text format output to a terminal for instrumentation profile.
(It cannot be portably tested. For sample profile, raw_fd_ostream is hidden deeply so it's inconvenient to add a diagnostic.)

Diff Detail

Event Timeline

MaskRay requested review of this revision.Jun 19 2021, 4:13 PM
MaskRay created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJun 19 2021, 4:13 PM
MaskRay edited the summary of this revision. (Show Details)Jun 19 2021, 4:14 PM
davidxl accepted this revision.Jun 19 2021, 4:37 PM

lgtm

This revision is now accepted and ready to land.Jun 19 2021, 4:37 PM
This revision was landed with ongoing or failed builds.Jun 21 2021, 12:02 PM
This revision was automatically updated to reflect the committed changes.