[libfuzzer] Disable failing DFSan-related tests

[gbalats]

Summary

These have been broken by https://reviews.llvm.org/D104494.
However, lib/fuzzer/dataflow/ is unused (?) so addressing this is not a priority.

Added TODOs to re-enable them in the future.

[vitalybuka]

compiler-rt/test/fuzzer/only-some-bytes-fork.test

5

Why this is on @kcc ?

[vitalybuka]

compiler-rt/test/fuzzer/only-some-bytes-fork.test

7

I guess line 7 is enough

[gbalats]

compiler-rt/test/fuzzer/only-some-bytes-fork.test

5

It was @kcc's suggestion.

7

I made it this way in case the test proves to be flaky (and not consistently fail 100% of the time), so that any coincidental successes do not cause breakages (XFAIL always expects failure, iiuc).

[dyung]

Can we get this change in sooner rather than later? This issue is causing failures in our internal build bot.

[gbalats]

In D104568#2828421, @dyung wrote:

Can we get this change in sooner rather than later? This issue is causing failures in our internal build bot.

Done.

[vitalybuka]

Thanks, LGTM

compiler-rt/lib/fuzzer/dataflow/DataFlow.cpp

 // Prints all instrumented functions.
 static int PrintFunctions() {
   // We don't have the symbolizer integrated with dfsan yet.
   // So use backtrace_symbols_fd and pipe it through llvm-symbolizer.
   // TODO(kcc): this is pretty ugly and may break in lots of ways.
   //      We'll need to make a proper in-process symbolizer work with DFSan.
   FILE *Pipe = popen("sed 's/(+/ /g; s/).*//g' "
                      "| llvm-symbolizer "
-                     "| grep 'dfs\\$' "
-                     "| sed 's/dfs\\$//g' "
+                     "| grep '\\.dfsan' "
+                     "| sed 's/\\.dfsan//g' "
                      "| c++filt",
                      "w");
   for (size_t I = 0; I < __dft.NumGuards; I++) {
     uintptr_t PC = __dft.PCsBeg[I * 2];
     if (!BlockIsEntry(I)) continue;
     void *const Buf[1] = {(void*)PC};
     backtrace_symbols_fd(Buf, 1, fileno(Pipe));
   }

compiler-rt/test/fuzzer/only-some-bytes-fork.test

 # Tests the data flow tracer.
 REQUIRES: linux, x86_64
 
+# Disabling due to dfs$ prefix to .dfsan suffix change in DFSan.
+# TODO(kcc): re-enable.
+RUN: false
+XFAIL: *
+
 # Build the tracer and the test.
-RUN: %no_fuzzer_cpp_compiler -c -fno-sanitize=all -fsanitize=dataflow %S/../../lib/fuzzer/dataflow/DataFlow.cpp -o  %t-DataFlow.o
-RUN: %no_fuzzer_cpp_compiler -c -fno-sanitize=all -fPIC                %S/../../lib/fuzzer/dataflow/DataFlowCallbacks.cpp -o  %t-DataFlowCallbacks.o
-RUN: %no_fuzzer_cpp_compiler    -fno-sanitize=all -fsanitize=dataflow -fsanitize-coverage=trace-pc-guard,pc-table,bb,trace-cmp   %S/OnlySomeBytesTest.cpp     %t-DataFlow*.o -o %t-DFT
-RUN: %cpp_compiler %S/OnlySomeBytesTest.cpp -o %t-Fuzz
+DISABLED: %no_fuzzer_cpp_compiler -c -fno-sanitize=all -fsanitize=dataflow %S/../../lib/fuzzer/dataflow/DataFlow.cpp -o  %t-DataFlow.o
+DISABLED: %no_fuzzer_cpp_compiler -c -fno-sanitize=all -fPIC                %S/../../lib/fuzzer/dataflow/DataFlowCallbacks.cpp -o  %t-DataFlowCallbacks.o
+DISABLED: %no_fuzzer_cpp_compiler    -fno-sanitize=all -fsanitize=dataflow -fsanitize-coverage=trace-pc-guard,pc-table,bb,trace-cmp   %S/OnlySomeBytesTest.cpp     %t-DataFlow*.o -o %t-DFT
+DISABLED: %cpp_compiler %S/OnlySomeBytesTest.cpp -o %t-Fuzz
 
 # Test that the fork mode can collect and use the DFT
-RUN: rm -rf %t && mkdir %t
-RUN: not %t-Fuzz -collect_data_flow=%t-DFT -use_value_profile=1 -runs=100000000 -fork=20 2> %t/log
-RUN: grep BINGO %t/log
+DISABLED: rm -rf %t && mkdir %t
+DISABLED: not %t-Fuzz -collect_data_flow=%t-DFT -use_value_profile=1 -runs=100000000 -fork=20 2> %t/log
+DISABLED: grep BINGO %t/log

compiler-rt/test/fuzzer/only-some-bytes.test

 # Tests the data flow tracer.
 REQUIRES: linux, x86_64
 
+# Disabling due to dfs$ prefix to .dfsan suffix change in DFSan.
+# TODO(kcc): re-enable.
+RUN: false
+XFAIL: *
+
 # Build the tracer and the test.
-RUN: %no_fuzzer_cpp_compiler -c -fno-sanitize=all -fsanitize=dataflow %S/../../lib/fuzzer/dataflow/DataFlow.cpp -o  %t-DataFlow.o
-RUN: %no_fuzzer_cpp_compiler -c -fno-sanitize=all -fPIC                %S/../../lib/fuzzer/dataflow/DataFlowCallbacks.cpp -o  %t-DataFlowCallbacks.o
-RUN: %no_fuzzer_cpp_compiler    -fno-sanitize=all -fsanitize=dataflow -fsanitize-coverage=trace-pc-guard,pc-table,bb,trace-cmp   %S/OnlySomeBytesTest.cpp     %t-DataFlow*.o -o %t-DFT
-RUN: %cpp_compiler %S/OnlySomeBytesTest.cpp -o %t-Fuzz
+DISABLED: %no_fuzzer_cpp_compiler -c -fno-sanitize=all -fsanitize=dataflow %S/../../lib/fuzzer/dataflow/DataFlow.cpp -o  %t-DataFlow.o
+DISABLED: %no_fuzzer_cpp_compiler -c -fno-sanitize=all -fPIC                %S/../../lib/fuzzer/dataflow/DataFlowCallbacks.cpp -o  %t-DataFlowCallbacks.o
+DISABLED: %no_fuzzer_cpp_compiler    -fno-sanitize=all -fsanitize=dataflow -fsanitize-coverage=trace-pc-guard,pc-table,bb,trace-cmp   %S/OnlySomeBytesTest.cpp     %t-DataFlow*.o -o %t-DFT
+DISABLED: %cpp_compiler %S/OnlySomeBytesTest.cpp -o %t-Fuzz
 
 # Prepare the inputs.
-RUN: rm -rf %t/*
-RUN: mkdir -p %t/IN
-RUN: echo -n 0123456789012345678901234567890123456789012345678901234567891234 > %t/IN/6
-RUN: cat  %t/IN/6 %t/IN/6 %t/IN/6 %t/IN/6 > %t/IN/8
-RUN: cat  %t/IN/8 %t/IN/8 %t/IN/8 %t/IN/8 > %t/IN/10
-RUN: cat  %t/IN/10 %t/IN/10 %t/IN/10 %t/IN/10 > %t/IN/12
+DISABLED: rm -rf %t/*
+DISABLED: mkdir -p %t/IN
+DISABLED: echo -n 0123456789012345678901234567890123456789012345678901234567891234 > %t/IN/6
+DISABLED: cat  %t/IN/6 %t/IN/6 %t/IN/6 %t/IN/6 > %t/IN/8
+DISABLED: cat  %t/IN/8 %t/IN/8 %t/IN/8 %t/IN/8 > %t/IN/10
+DISABLED: cat  %t/IN/10 %t/IN/10 %t/IN/10 %t/IN/10 > %t/IN/12
 # %t/IN/12 is 4096 bytes-long.
 
-RUN: %t-Fuzz -focus_function='fB(unsigned char const*)' -runs=0 %t/IN 2>&1 | FileCheck %s --check-prefix=FOCUS_fB
+DISABLED: %t-Fuzz -focus_function='fB(unsigned char const*)' -runs=0 %t/IN 2>&1 | FileCheck %s --check-prefix=FOCUS_fB
 FOCUS_fB: Focus function is set to 'fB(unsigned char const*)'
 
-RUN: %t-Fuzz -focus_function=f0 -runs=0 %t/IN 2>&1 | FileCheck %s --check-prefix=NO_FOCUSED_INPUT
+DISABLED: %t-Fuzz -focus_function=f0 -runs=0 %t/IN 2>&1 | FileCheck %s --check-prefix=NO_FOCUSED_INPUT
 NO_FOCUSED_INPUT: Focus function is set to 'f0'
 NO_FOCUSED_INPUT: INFO: 0/2 inputs touch the focus function
 
-RUN: (echo -n ABC; cat %t/IN/12) > %t/IN/ABC
-RUN: %t-Fuzz -focus_function=f0 -runs=0 %t/IN 2>&1 | FileCheck %s --check-prefix=ONE_FOCUSED_INPUT
+DISABLED: (echo -n ABC; cat %t/IN/12) > %t/IN/ABC
+DISABLED: %t-Fuzz -focus_function=f0 -runs=0 %t/IN 2>&1 | FileCheck %s --check-prefix=ONE_FOCUSED_INPUT
 ONE_FOCUSED_INPUT: INFO: 1/3 inputs touch the focus function
 
-RUN: rm -rf %t/IN_DFT
-RUN: %t-Fuzz -collect_data_flow=%t-DFT %t/IN -data_flow_trace=%t/IN_DFT > /dev/null 2>&1
+DISABLED: rm -rf %t/IN_DFT
+DISABLED: %t-Fuzz -collect_data_flow=%t-DFT %t/IN -data_flow_trace=%t/IN_DFT > /dev/null 2>&1
 
 # Repeat twice to make sure that the inputs with DFT are not removed from the corpus.
-RUN: %t-Fuzz -focus_function=f0 -data_flow_trace=%t/IN_DFT -runs=100 %t/IN 2>&1 | FileCheck %s --check-prefix=HAVE_DFT
-RUN: %t-Fuzz -focus_function=f0 -data_flow_trace=%t/IN_DFT -runs=100 %t/IN 2>&1 | FileCheck %s --check-prefix=HAVE_DFT
+DISABLED: %t-Fuzz -focus_function=f0 -data_flow_trace=%t/IN_DFT -runs=100 %t/IN 2>&1 | FileCheck %s --check-prefix=HAVE_DFT
+DISABLED: %t-Fuzz -focus_function=f0 -data_flow_trace=%t/IN_DFT -runs=100 %t/IN 2>&1 | FileCheck %s --check-prefix=HAVE_DFT
 HAVE_DFT: INFO: 1/{{.*}} inputs have the Data Flow Trace
 
 # Collect DFT, then use it.
-RUN: rm -rf %t/C %t/C1  && mkdir %t/C %t/C1 &&  cp %t/IN/* %t/C
-RUN: rm -rf %t/C_DFT && %t-Fuzz -collect_data_flow=%t-DFT %t/C -data_flow_trace=%t/C_DFT > /dev/null 2>&1
-RUN: not %t-Fuzz -focus_function=f0 -data_flow_trace=%t/C_DFT -seed=1 -runs=1000000 -use_value_profile=1 %t/C1 %t/C 2> %t/log
-RUN: grep BINGO %t/log
+DISABLED: rm -rf %t/C %t/C1  && mkdir %t/C %t/C1 &&  cp %t/IN/* %t/C
+DISABLED: rm -rf %t/C_DFT && %t-Fuzz -collect_data_flow=%t-DFT %t/C -data_flow_trace=%t/C_DFT > /dev/null 2>&1
+DISABLED: not %t-Fuzz -focus_function=f0 -data_flow_trace=%t/C_DFT -seed=1 -runs=1000000 -use_value_profile=1 %t/C1 %t/C 2> %t/log
+DISABLED: grep BINGO %t/log
 
 # Test -focus_function=auto: run 100 times and verify that
 #  * 'f0' is the most frequent focus function.
 #  * the second most frequent is one of fA/fB/fC in a de-mangled form.
-RUN: %t-Fuzz -focus_function=auto -data_flow_trace=%t/C_DFT -runs=0 %t/C -jobs=100 2>&1 | grep AUTOFOCUS  | sort | uniq -c | sort -g -r | head -n 2 | FileCheck %s --check-prefix=AUTOFOCUS
+DISABLED: %t-Fuzz -focus_function=auto -data_flow_trace=%t/C_DFT -runs=0 %t/C -jobs=100 2>&1 | grep AUTOFOCUS  | sort | uniq -c | sort -g -r | head -n 2 | FileCheck %s --check-prefix=AUTOFOCUS
 AUTOFOCUS: INFO: AUTOFOCUS: {{.*}} f0
 AUTOFOCUS: INFO: AUTOFOCUS: {{.*f[ABC]}}(unsigned char const*)
 
 # Actually execute 50 fuzzing processes with a small number of runs, to test  -focus_function=auto for real.
 # We can not test data_flow_trace=auto in just a single run, because it may choose to focus on a wrong function.
-RUN: not %t-Fuzz -focus_function=auto -data_flow_trace=%t/C_DFT %t/C -jobs=50 -runs=200000 -use_value_profile=1 2> %t/log
-RUN: grep BINGO %t/log
+DISABLED: not %t-Fuzz -focus_function=auto -data_flow_trace=%t/C_DFT %t/C -jobs=50 -runs=200000 -use_value_profile=1 2> %t/log
+DISABLED: grep BINGO %t/log