This is an archive of the discontinued LLVM Phabricator instance.

Differential D104549

[NFC][libomptarget] Remove redundant libelf dependency for elf_common.
ClosedPublic

Authored by vzakhari on Jun 18 2021, 9:48 AM.

Download Raw Diff

Details

Reviewers

JonChesterfield
ronlieb
jdoerfert

Commits

rGaad9e48c5fc7: [NFC][libomptarget] Remove redundant libelf dependency for elf_common.

Summary

This dependency is not needed now.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

vzakhari created this revision.Jun 18 2021, 9:48 AM

Herald added a subscriber: mgorny. · View Herald TranscriptJun 18 2021, 9:48 AM

vzakhari requested review of this revision.Jun 18 2021, 9:48 AM

Herald added a project: Restricted Project. · View Herald TranscriptJun 18 2021, 9:48 AM

Herald added a subscriber: openmp-commits. · View Herald Transcript

works for me

This revision is now accepted and ready to land.Jun 18 2021, 10:12 AM

Herald added a reviewer: jdoerfert. · View Herald TranscriptJun 18 2021, 10:12 AM

Herald added a subscriber: sstefan1. · View Herald Transcript

Harbormaster completed remote builds in B109955: Diff 353036.Jun 19 2021, 3:57 AM

Closed by commit rGaad9e48c5fc7: [NFC][libomptarget] Remove redundant libelf dependency for elf_common. (authored by vzakhari). · Explain WhyJun 21 2021, 7:21 AM

This revision was automatically updated to reflect the committed changes.

vzakhari added a commit: rGaad9e48c5fc7: [NFC][libomptarget] Remove redundant libelf dependency for elf_common..

Revision Contents

Path

Size

openmp/

libomptarget/

plugins/

common/

elf_common/

2 lines

Diff 353363

openmp/libomptarget/plugins/common/elf_common/CMakeLists.txt

	Show All 10 Lines
	##===----------------------------------------------------------------------===##			##===----------------------------------------------------------------------===##

	add_library(elf_common OBJECT elf_common.cpp)			add_library(elf_common OBJECT elf_common.cpp)

	# Build elf_common with PIC to be able to link it with plugin shared libraries.			# Build elf_common with PIC to be able to link it with plugin shared libraries.
	set_property(TARGET elf_common PROPERTY POSITION_INDEPENDENT_CODE ON)			set_property(TARGET elf_common PROPERTY POSITION_INDEPENDENT_CODE ON)
	llvm_update_compile_flags(elf_common)			llvm_update_compile_flags(elf_common)
	set(LINK_LLVM_LIBS LLVMBinaryFormat LLVMObject LLVMSupport)			set(LINK_LLVM_LIBS LLVMBinaryFormat LLVMObject LLVMSupport)
	target_link_libraries(elf_common INTERFACE ${LINK_LLVM_LIBS} ${LIBOMPTARGET_DEP_LIBELF_LIBRARIES})			target_link_libraries(elf_common INTERFACE ${LINK_LLVM_LIBS})
	include_directories(${LIBOMPTARGET_LLVM_INCLUDE_DIRS})			include_directories(${LIBOMPTARGET_LLVM_INCLUDE_DIRS})
	add_dependencies(elf_common ${LINK_LLVM_LIBS})			add_dependencies(elf_common ${LINK_LLVM_LIBS})

	# The code uses Debug.h, which requires threads support.			# The code uses Debug.h, which requires threads support.
	target_link_libraries(elf_common INTERFACE ${OPENMP_PTHREAD_LIB})			target_link_libraries(elf_common INTERFACE ${OPENMP_PTHREAD_LIB})

	# Expose elf_common.h directory to the users of this library.			# Expose elf_common.h directory to the users of this library.
	target_include_directories(elf_common INTERFACE ${CMAKE_CURRENT_SOURCE_DIR})			target_include_directories(elf_common INTERFACE ${CMAKE_CURRENT_SOURCE_DIR})