Allow building for release with EXPENSIVE_CHECKS

[tmatheson]

Summary

D97225 moved LazyCallGraph verify() calls behind EXPENSIVE_CHECKS,
but verity() is defined for debug builds only so this had the unintended
effect of breaking release builds with EXPENSIVE_CHECKS.

Fix by enabling verify() for both debug and EXPENSIVE_CHECKS.

llvm/include/llvm/Analysis/LazyCallGraph.h

friend raw_ostream &operator<<(raw_ostream &OS, const SCC &C) {
       }
       OS << ')';
       return OS;
     }
 
     /// Dump a short description of this SCC to stderr.
     void dump() const;
 
-#ifndef NDEBUG
+#if !defined(NDEBUG) || defined(EXPENSIVE_CHECKS)
     /// Verify invariants about the SCC.
     ///
     /// This will attempt to validate all of the basic invariants within an
     /// SCC, but not that it is a strongly connected componet per-se. Primarily
     /// useful while building and updating the graph to check that basic
     /// properties are in place rather than having inexplicable crashes later.
     void verify();
 #endif
friend raw_ostream &operator<<(raw_ostream &OS, const RefSCC &RC) {
       }
       OS << ']';
       return OS;
     }
 
     /// Dump a short description of this RefSCC to stderr.
     void dump() const;
 
-#ifndef NDEBUG
+#if !defined(NDEBUG) || defined(EXPENSIVE_CHECKS)
     /// Verify invariants about the RefSCC and all its SCCs.
     ///
     /// This will attempt to validate all of the invariants *within* the
     /// RefSCC, but not that it is a strongly connected component of the larger
     /// graph. This makes it useful even when partially through an update.
     ///
     /// Invariants checked:
     /// - SCCs and their indices match.

llvm/lib/Analysis/LazyCallGraph.cpp

 }
 
 #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
 LLVM_DUMP_METHOD void LazyCallGraph::SCC::dump() const {
   dbgs() << *this << '\n';
 }
 #endif
 
-#ifndef NDEBUG
+#if !defined(NDEBUG) || defined(EXPENSIVE_CHECKS)
 void LazyCallGraph::SCC::verify() {
   assert(OuterRefSCC && "Can't have a null RefSCC!");
   assert(!Nodes.empty() && "Can't have an empty SCC!");
 
   for (Node *N : Nodes) {
     assert(N && "Can't have a null node!");
     assert(OuterRefSCC->G->lookupSCC(*N) == this &&
            "Node does not map to this SCC!");

 LazyCallGraph::RefSCC::RefSCC(LazyCallGraph &G) : G(&G) {}
 
 #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
 LLVM_DUMP_METHOD void LazyCallGraph::RefSCC::dump() const {
   dbgs() << *this << '\n';
 }
 #endif
 
-#ifndef NDEBUG
+#if !defined(NDEBUG) || defined(EXPENSIVE_CHECKS)
 void LazyCallGraph::RefSCC::verify() {
   assert(G && "Can't have a null graph!");
   assert(!SCCs.empty() && "Can't have an empty SCC!");
 
   // Verify basic properties of the SCCs.
   SmallPtrSet<SCC *, 4> SCCSet;
   for (SCC *C : SCCs) {
     assert(C && "Can't have a null SCC!");