This is an archive of the discontinued LLVM Phabricator instance.

[CSSPGO][llvm-profgen] Fix an issue in findDisjointRanges
ClosedPublic

Authored by hoy on Jun 17 2021, 6:04 PM.

Details

Summary

We were using 0 as an indicator of invalid offset when computing disjoint ranges. In reality, 0 can be an valid code offset which stands for the first function in .text section. I'm using UINT64_MAX as an invalid code offset instead.

Diff Detail

Unit TestsFailed

Event Timeline

hoy created this revision.Jun 17 2021, 6:04 PM
hoy requested review of this revision.Jun 17 2021, 6:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 17 2021, 6:04 PM
wenlei accepted this revision.Jun 18 2021, 10:42 AM

lgtm, thanks for the fix.

This revision is now accepted and ready to land.Jun 18 2021, 10:42 AM
This revision was landed with ongoing or failed builds.Jun 18 2021, 2:39 PM
This revision was automatically updated to reflect the committed changes.