Page MenuHomePhabricator

[OpenMP] Update FAQ with additional instructions for enabling cuda offloading
ClosedPublic

Authored by ashermancinelli on Jun 17 2021, 10:20 AM.

Details

Summary

Add an FAQ entry and add a few lines to another one. Document the use of CCC_OVERRIDE_OPTIONS for injecting GCC toolchain path.

Diff Detail

Event Timeline

ashermancinelli requested review of this revision.Jun 17 2021, 10:20 AM

Thanks for improving the documentation. Some comments, the documentation should be generic over specific cmake invocations / gcc versions and errors.

openmp/docs/SupportAndFAQ.rst
61

I'd just say something like "If building OpenMP with LLVM_ENABLE_RUNTIMES, OpenMP should not be enabled as a project in LLVM_ENABLE_PROJECTS because it is enabled by default."

222

No need to be specific to GCC 9.1.0.

229

Don't give a specific cmake invocation, we can just refer to the existing documentation for setting up CMake as above.

Remove CMake example. Use more generic language.

ashermancinelli marked 3 inline comments as done.Jun 17 2021, 11:36 AM

I've hopefully addressed your comments. Thanks for the review @jhuber6!

Document use of CMake variable GCC_INSTALL_PREFIX over ugly workaround.

jhuber6 accepted this revision.Jun 17 2021, 4:09 PM
jhuber6 added inline comments.
openmp/docs/SupportAndFAQ.rst
217

No longer relevant.

This revision is now accepted and ready to land.Jun 17 2021, 4:09 PM

Update language to use cmake variables over ugly environment variable workaround.

This revision was landed with ongoing or failed builds.Jun 18 2021, 10:57 AM
This revision was automatically updated to reflect the committed changes.