This is an archive of the discontinued LLVM Phabricator instance.

[libc++abi] NFC: avoid a -Wunused-parameter warning
ClosedPublic

Authored by xingxue on Jun 14 2021, 8:48 AM.

Details

Summary

A -Wunused-parameter warning was introduced by patch rG7f0244afa828 [libc++abi] NFC: adding a new parameter base to functions for calculating… (authored by xingxue). The unused parameter base will be used in a follow-on patch D101298. This patch is to avoid the warning before D101298 is landed.

Diff Detail

Event Timeline

xingxue requested review of this revision.Jun 14 2021, 8:48 AM
xingxue created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJun 14 2021, 8:48 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne requested changes to this revision.Jun 14 2021, 11:01 AM
ldionne added inline comments.
libcxxabi/src/cxa_personality.cpp
248–254
This revision now requires changes to proceed.Jun 14 2021, 11:01 AM
xingxue updated this revision to Diff 351936.Jun 14 2021, 11:27 AM

Addressed the comment on fixing the unused parameter base.

xingxue marked an inline comment as done.Jun 14 2021, 11:28 AM
xingxue added inline comments.
libcxxabi/src/cxa_personality.cpp
248–254

Changed as suggested, thanks!

ldionne accepted this revision.Jun 14 2021, 11:53 AM

Thanks!

This revision is now accepted and ready to land.Jun 14 2021, 11:53 AM
This revision was landed with ongoing or failed builds.Jun 14 2021, 1:06 PM
This revision was automatically updated to reflect the committed changes.
xingxue marked an inline comment as done.