This is an archive of the discontinued LLVM Phabricator instance.

Differential D104215

[llvm-dlltool] [test] Add a testcase for all machine option types. NFC.
ClosedPublic

Authored by mstorsjo on Jun 14 2021, 3:41 AM.

Details

Reviewers
rnk
mati865
Commits
rG675d52bc46ff: [llvm-dlltool] [test] Add a testcase for all machine option types. NFC.
Summary

The existing tests only test that some options (but not e.g. arm)
are accepted, but it doesn't test their functional effect of
affecting the generated object files.

Diff Detail

Event Timeline

mstorsjo created this revision.Jun 14 2021, 3:41 AM
Herald added subscribers: ormris, steven_wu, hiraditya and 2 others. · View Herald TranscriptJun 14 2021, 3:41 AM
mstorsjo requested review of this revision.Jun 14 2021, 3:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 14 2021, 3:41 AM
Harbormaster completed remote builds in B109068: Diff 351818.Jun 14 2021, 4:44 AM
mati865 accepted this revision.Jun 14 2021, 2:52 PM

LGTM

This revision is now accepted and ready to land.Jun 14 2021, 2:52 PM
Closed by commit rG675d52bc46ff: [llvm-dlltool] [test] Add a testcase for all machine option types. NFC. (authored by mstorsjo). · Explain WhyJun 17 2021, 3:03 AM
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rG675d52bc46ff: [llvm-dlltool] [test] Add a testcase for all machine option types. NFC..

Revision Contents

PathSize
llvm/
test/
tools/
llvm-dlltool/
17 lines

Diff 352662

llvm/test/tools/llvm-dlltool/machine-opt.def

  • This file was added.
; RUN: llvm-dlltool -m i386 -d %s -l %t.a
; RUN: llvm-readobj %t.a | FileCheck --check-prefix=I386 %s
; RUN: llvm-dlltool -m i386:x86-64 -d %s -l %t.a
; RUN: llvm-readobj %t.a | FileCheck --check-prefix=X86_64 %s
; RUN: llvm-dlltool -m arm -d %s -l %t.a
; RUN: llvm-readobj %t.a | FileCheck --check-prefix=ARM %s
; RUN: llvm-dlltool -m arm64 -d %s -l %t.a
; RUN: llvm-readobj %t.a | FileCheck --check-prefix=ARM64 %s
LIBRARY test.dll
EXPORTS
TestFunction
; I386: Format: COFF-i386
; X86_64: Format: COFF-x86-64
; ARM: Format: COFF-ARM{{$}}
; ARM64: Format: COFF-ARM64