Page MenuHomePhabricator

[clang][deps] NFC: Stop using moved-from object
ClosedPublic

Authored by jansvoboda11 on Jun 11 2021, 3:47 AM.

Details

Summary

The dependency scanning worker uses std::move to "reset" DependencyOutputOptions in the CompilerInstance that performs the implicit build. It's probably preferable to replace the object with value-initialized instance, rather than depending on the behavior of a moved-from object.

Diff Detail

Event Timeline

jansvoboda11 requested review of this revision.Jun 11 2021, 3:47 AM
jansvoboda11 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJun 11 2021, 3:47 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
This revision is now accepted and ready to land.Jun 13 2021, 12:57 PM
This revision was landed with ongoing or failed builds.Jun 14 2021, 6:16 AM
This revision was automatically updated to reflect the committed changes.