Page MenuHomePhabricator

Set local_unnamed_addr for new library function declarations in InjectTLIMappings.
Needs ReviewPublic

Authored by tianqing on Jun 9 2021, 12:55 AM.

Details

Reviewers
fhahn
fpetrogalli
Summary

When InjectTLIMappings constructs the list of vector functions for VFABI attribute, it tries to find each of the functions in the module. If it's absent, a new function declaration is added. In this case, we know the newly added vector function is not used by the original translation unit. It's address is also not used, thus it's good to mark its address insignificant at least at module level.

Diff Detail

Unit TestsFailed

TimeTest
270 msx64 debian > LLVM.CodeGen/AArch64::dag-combine-insert-subvector.ll
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/llc < /var/lib/buildkite-agent/builds/llvm-project/llvm/test/CodeGen/AArch64/dag-combine-insert-subvector.ll -o /dev/null
360 msx64 debian > LLVM.CodeGen/AArch64::inline-asm-constraints-bad-sve.ll
Script: -- : 'RUN: at line 1'; not /var/lib/buildkite-agent/builds/llvm-project/build/bin/llc -mtriple=aarch64-none-linux-gnu -mattr=+sve -o - /var/lib/buildkite-agent/builds/llvm-project/llvm/test/CodeGen/AArch64/inline-asm-constraints-bad-sve.ll 2>&1 | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/llvm/test/CodeGen/AArch64/inline-asm-constraints-bad-sve.ll
260 msx64 debian > LLVM.CodeGen/AArch64::named-vector-shuffles-sve.ll
Script: -- : 'RUN: at line 2'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/llc -verify-machineinstrs < /var/lib/buildkite-agent/builds/llvm-project/llvm/test/CodeGen/AArch64/named-vector-shuffles-sve.ll | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/llvm/test/CodeGen/AArch64/named-vector-shuffles-sve.ll
270 msx64 debian > LLVM.CodeGen/AArch64::spillfill-sve.ll
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/llc -mtriple=aarch64-none-linux-gnu -mattr=+sve -mattr=+bf16 < /var/lib/buildkite-agent/builds/llvm-project/llvm/test/CodeGen/AArch64/spillfill-sve.ll | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/llvm/test/CodeGen/AArch64/spillfill-sve.ll
380 msx64 debian > LLVM.CodeGen/AArch64::split-vector-insert.ll
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/llc < /var/lib/buildkite-agent/builds/llvm-project/llvm/test/CodeGen/AArch64/split-vector-insert.ll -debug-only=legalize-types 2>&1 | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/llvm/test/CodeGen/AArch64/split-vector-insert.ll --check-prefix=CHECK-LEGALIZATION
View Full Test Results (311 Failed)

Event Timeline

tianqing created this revision.Jun 9 2021, 12:55 AM
tianqing requested review of this revision.Jun 9 2021, 12:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 9 2021, 12:55 AM
tianqing updated this revision to Diff 350805.Jun 9 2021, 1:12 AM
fhahn added a comment.Jun 9 2021, 2:46 AM

Please update the description of the patch with a motivation for the fix and why it is the right thing to do. This will make the change easier to review.

tianqing edited the summary of this revision. (Show Details)Jun 10 2021, 1:22 AM
tianqing updated this revision to Diff 351088.Jun 10 2021, 1:25 AM

Fix typos.