This is an archive of the discontinued LLVM Phabricator instance.

Differential D103926

[CMake][Fuchsia] Disable vcruntime for first stage as well
ClosedPublic

Authored by phosek on Jun 8 2021, 1:42 PM.

Details

Reviewers
haowei
leonardchan
Commits
rG1683dbf0ddb2: [CMake][Fuchsia] Disable vcruntime for first stage as well
Summary

Using vcruntime is breaking libc++ headers so don't use it.

Diff Detail

Event Timeline

phosek created this revision.Jun 8 2021, 1:42 PM
Herald added a subscriber: mgorny. · View Herald TranscriptJun 8 2021, 1:42 PM
phosek requested review of this revision.Jun 8 2021, 1:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 8 2021, 1:42 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
haowei accepted this revision.Jun 8 2021, 1:43 PM
This revision is now accepted and ready to land.Jun 8 2021, 1:43 PM
This revision was landed with ongoing or failed builds.Jun 8 2021, 1:44 PM
Closed by commit rG1683dbf0ddb2: [CMake][Fuchsia] Disable vcruntime for first stage as well (authored by phosek). · Explain Why
This revision was automatically updated to reflect the committed changes.
phosek added a commit: rG1683dbf0ddb2: [CMake][Fuchsia] Disable vcruntime for first stage as well.
Harbormaster completed remote builds in B108279: Diff 350704.Jun 8 2021, 1:58 PM

Revision Contents

PathSize
clang/
cmake/
caches/
1 line

Diff 350705

clang/cmake/caches/Fuchsia.cmake

Show First 20 Lines • Show All 60 Lines • ▼ Show 20 Lines
set(LIBCXX_ABI_VERSION 2 CACHE STRING "") set(LIBCXX_ABI_VERSION 2 CACHE STRING "")
set(LIBCXX_ENABLE_SHARED OFF CACHE BOOL "") set(LIBCXX_ENABLE_SHARED OFF CACHE BOOL "")
if(WIN32) if(WIN32)
set(LIBCXX_HAS_WIN32_THREAD_API ON CACHE BOOL "") set(LIBCXX_HAS_WIN32_THREAD_API ON CACHE BOOL "")
set(LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY OFF CACHE BOOL "") set(LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY OFF CACHE BOOL "")
set(LIBCXX_ENABLE_FILESYSTEM OFF CACHE BOOL "") set(LIBCXX_ENABLE_FILESYSTEM OFF CACHE BOOL "")
set(LIBCXX_ENABLE_ABI_LINKER_SCRIPT OFF CACHE BOOL "") set(LIBCXX_ENABLE_ABI_LINKER_SCRIPT OFF CACHE BOOL "")
set(LIBCXX_ENABLE_STATIC_ABI_LIBRARY OFF CACHE BOOL "") set(LIBCXX_ENABLE_STATIC_ABI_LIBRARY OFF CACHE BOOL "")
set(LIBCXX_NO_VCRUNTIME ON CACHE BOOL "")
set(BUILTINS_CMAKE_ARGS -DCMAKE_SYSTEM_NAME=Windows CACHE STRING "") set(BUILTINS_CMAKE_ARGS -DCMAKE_SYSTEM_NAME=Windows CACHE STRING "")
set(RUNTIMES_CMAKE_ARGS -DCMAKE_SYSTEM_NAME=Windows CACHE STRING "") set(RUNTIMES_CMAKE_ARGS -DCMAKE_SYSTEM_NAME=Windows CACHE STRING "")
set(LLVM_ENABLE_RUNTIMES "compiler-rt;libcxx" CACHE STRING "") set(LLVM_ENABLE_RUNTIMES "compiler-rt;libcxx" CACHE STRING "")
else() else()
set(LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "") set(LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "")
set(LLVM_ENABLE_RUNTIMES "compiler-rt;libcxx;libcxxabi;libunwind" CACHE STRING "") set(LLVM_ENABLE_RUNTIMES "compiler-rt;libcxx;libcxxabi;libunwind" CACHE STRING "")
endif() endif()
▲ Show 20 Lines • Show All 80 Lines • Show Last 20 Lines