This is an archive of the discontinued LLVM Phabricator instance.

Differential D103883

[ValueTypes] Add missing enum names for MVTs
ClosedPublic

Authored by frasercrmck on Jun 8 2021, 3:44 AM.

Details

Reviewers
craig.topper
RKSimon
efriedma
Commits
rG80d556441adc: [ValueTypes] Add missing enum names for MVTs
Summary

These types are (presumably) never used in the generated TableGen files.
The default switch case silences any compiler warnings for these
missing types so it's easy to miss.

Diff Detail

Event Timeline

frasercrmck requested review of this revision.Jun 8 2021, 3:44 AM
frasercrmck created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJun 8 2021, 3:44 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B108184: Diff 350564.Jun 8 2021, 4:16 AM
craig.topper accepted this revision.Jun 8 2021, 10:09 AM

LGTM

This revision is now accepted and ready to land.Jun 8 2021, 10:09 AM
This revision was landed with ongoing or failed builds.Jun 9 2021, 1:49 AM
Closed by commit rG80d556441adc: [ValueTypes] Add missing enum names for MVTs (authored by frasercrmck). · Explain Why
This revision was automatically updated to reflect the committed changes.
frasercrmck added a commit: rG80d556441adc: [ValueTypes] Add missing enum names for MVTs.

Revision Contents

PathSize
llvm/
utils/
TableGen/
4 lines

Diff 350818

llvm/utils/TableGen/CodeGenTarget.cpp

Show First 20 Lines • Show All 102 Lines • ▼ Show 20 LinesStringRef llvm::getEnumName(MVT::SimpleValueType T) {
case MVT::v2i16: return "MVT::v2i16"; case MVT::v2i16: return "MVT::v2i16";
case MVT::v3i16: return "MVT::v3i16"; case MVT::v3i16: return "MVT::v3i16";
case MVT::v4i16: return "MVT::v4i16"; case MVT::v4i16: return "MVT::v4i16";
case MVT::v8i16: return "MVT::v8i16"; case MVT::v8i16: return "MVT::v8i16";
case MVT::v16i16: return "MVT::v16i16"; case MVT::v16i16: return "MVT::v16i16";
case MVT::v32i16: return "MVT::v32i16"; case MVT::v32i16: return "MVT::v32i16";
case MVT::v64i16: return "MVT::v64i16"; case MVT::v64i16: return "MVT::v64i16";
case MVT::v128i16: return "MVT::v128i16"; case MVT::v128i16: return "MVT::v128i16";
case MVT::v256i16: return "MVT::v256i16";
case MVT::v1i32: return "MVT::v1i32"; case MVT::v1i32: return "MVT::v1i32";
case MVT::v2i32: return "MVT::v2i32"; case MVT::v2i32: return "MVT::v2i32";
case MVT::v3i32: return "MVT::v3i32"; case MVT::v3i32: return "MVT::v3i32";
case MVT::v4i32: return "MVT::v4i32"; case MVT::v4i32: return "MVT::v4i32";
case MVT::v5i32: return "MVT::v5i32"; case MVT::v5i32: return "MVT::v5i32";
case MVT::v8i32: return "MVT::v8i32"; case MVT::v8i32: return "MVT::v8i32";
case MVT::v16i32: return "MVT::v16i32"; case MVT::v16i32: return "MVT::v16i32";
case MVT::v32i32: return "MVT::v32i32"; case MVT::v32i32: return "MVT::v32i32";
case MVT::v64i32: return "MVT::v64i32"; case MVT::v64i32: return "MVT::v64i32";
case MVT::v128i32: return "MVT::v128i32"; case MVT::v128i32: return "MVT::v128i32";
case MVT::v256i32: return "MVT::v256i32"; case MVT::v256i32: return "MVT::v256i32";
case MVT::v512i32: return "MVT::v512i32"; case MVT::v512i32: return "MVT::v512i32";
case MVT::v1024i32: return "MVT::v1024i32"; case MVT::v1024i32: return "MVT::v1024i32";
case MVT::v2048i32: return "MVT::v2048i32"; case MVT::v2048i32: return "MVT::v2048i32";
case MVT::v1i64: return "MVT::v1i64"; case MVT::v1i64: return "MVT::v1i64";
case MVT::v2i64: return "MVT::v2i64"; case MVT::v2i64: return "MVT::v2i64";
case MVT::v4i64: return "MVT::v4i64"; case MVT::v4i64: return "MVT::v4i64";
case MVT::v8i64: return "MVT::v8i64"; case MVT::v8i64: return "MVT::v8i64";
case MVT::v16i64: return "MVT::v16i64"; case MVT::v16i64: return "MVT::v16i64";
case MVT::v32i64: return "MVT::v32i64"; case MVT::v32i64: return "MVT::v32i64";
case MVT::v64i64: return "MVT::v64i64"; case MVT::v64i64: return "MVT::v64i64";
case MVT::v128i64: return "MVT::v128i64"; case MVT::v128i64: return "MVT::v128i64";
case MVT::v256i64: return "MVT::v256i64"; case MVT::v256i64: return "MVT::v256i64";
case MVT::v1i128: return "MVT::v1i128"; case MVT::v1i128: return "MVT::v1i128";
case MVT::v1f16: return "MVT::v1f16";
case MVT::v2f16: return "MVT::v2f16"; case MVT::v2f16: return "MVT::v2f16";
case MVT::v3f16: return "MVT::v3f16"; case MVT::v3f16: return "MVT::v3f16";
case MVT::v4f16: return "MVT::v4f16"; case MVT::v4f16: return "MVT::v4f16";
case MVT::v8f16: return "MVT::v8f16"; case MVT::v8f16: return "MVT::v8f16";
case MVT::v16f16: return "MVT::v16f16"; case MVT::v16f16: return "MVT::v16f16";
case MVT::v32f16: return "MVT::v32f16"; case MVT::v32f16: return "MVT::v32f16";
case MVT::v64f16: return "MVT::v64f16"; case MVT::v64f16: return "MVT::v64f16";
case MVT::v128f16: return "MVT::v128f16"; case MVT::v128f16: return "MVT::v128f16";
case MVT::v256f16: return "MVT::v256f16";
case MVT::v2bf16: return "MVT::v2bf16"; case MVT::v2bf16: return "MVT::v2bf16";
case MVT::v3bf16: return "MVT::v3bf16"; case MVT::v3bf16: return "MVT::v3bf16";
case MVT::v4bf16: return "MVT::v4bf16"; case MVT::v4bf16: return "MVT::v4bf16";
case MVT::v8bf16: return "MVT::v8bf16"; case MVT::v8bf16: return "MVT::v8bf16";
case MVT::v16bf16: return "MVT::v16bf16"; case MVT::v16bf16: return "MVT::v16bf16";
case MVT::v32bf16: return "MVT::v32bf16"; case MVT::v32bf16: return "MVT::v32bf16";
case MVT::v64bf16: return "MVT::v64bf16"; case MVT::v64bf16: return "MVT::v64bf16";
case MVT::v128bf16: return "MVT::v128bf16"; case MVT::v128bf16: return "MVT::v128bf16";
▲ Show 20 Lines • Show All 53 Lines • ▼ Show 20 LinesStringRef llvm::getEnumName(MVT::SimpleValueType T) {
case MVT::nxv16i64: return "MVT::nxv16i64"; case MVT::nxv16i64: return "MVT::nxv16i64";
case MVT::nxv32i64: return "MVT::nxv32i64"; case MVT::nxv32i64: return "MVT::nxv32i64";
case MVT::nxv1f16: return "MVT::nxv1f16"; case MVT::nxv1f16: return "MVT::nxv1f16";
case MVT::nxv2f16: return "MVT::nxv2f16"; case MVT::nxv2f16: return "MVT::nxv2f16";
case MVT::nxv4f16: return "MVT::nxv4f16"; case MVT::nxv4f16: return "MVT::nxv4f16";
case MVT::nxv8f16: return "MVT::nxv8f16"; case MVT::nxv8f16: return "MVT::nxv8f16";
case MVT::nxv16f16: return "MVT::nxv16f16"; case MVT::nxv16f16: return "MVT::nxv16f16";
case MVT::nxv32f16: return "MVT::nxv32f16"; case MVT::nxv32f16: return "MVT::nxv32f16";
case MVT::nxv1bf16: return "MVT::nxv1bf16";
case MVT::nxv2bf16: return "MVT::nxv2bf16"; case MVT::nxv2bf16: return "MVT::nxv2bf16";
case MVT::nxv4bf16: return "MVT::nxv4bf16"; case MVT::nxv4bf16: return "MVT::nxv4bf16";
case MVT::nxv8bf16: return "MVT::nxv8bf16"; case MVT::nxv8bf16: return "MVT::nxv8bf16";
case MVT::nxv1f32: return "MVT::nxv1f32"; case MVT::nxv1f32: return "MVT::nxv1f32";
case MVT::nxv2f32: return "MVT::nxv2f32"; case MVT::nxv2f32: return "MVT::nxv2f32";
case MVT::nxv4f32: return "MVT::nxv4f32"; case MVT::nxv4f32: return "MVT::nxv4f32";
case MVT::nxv8f32: return "MVT::nxv8f32"; case MVT::nxv8f32: return "MVT::nxv8f32";
case MVT::nxv16f32: return "MVT::nxv16f32"; case MVT::nxv16f32: return "MVT::nxv16f32";
▲ Show 20 Lines • Show All 692 Lines • Show Last 20 Lines