This is an archive of the discontinued LLVM Phabricator instance.

Differential D103843

Parallel-libs/.clang-tidy: Remove broken config and simplify existing one to use inheritance from the root .clang-tidy
AbandonedPublic

Authored by dblaikie on Jun 7 2021, 2:25 PM.

Details

Reviewers
arsenm
Summary

parallel-libs/.clang-tidy seems to have been broken from the start (but
unused) due to using "lowerCase" as a format name (rather than
"lower_case") which actually crashes clang-tidy. But since no code is in
that directory, all uses of clang-tidy used the override in
acxxel/.clang-tidy.

So to simplify things, I've sunk the acxxel format down/up into the
general format, and changed it to use inheritance from the llvm monorepo
root .clang-tidy for simplicity/so it can inherit features from there.

Diff Detail

Event Timeline

dblaikie requested review of this revision.Jun 7 2021, 2:25 PM
dblaikie created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJun 7 2021, 2:25 PM
Herald added subscribers: llvm-commits, aheejin, wdng. · View Herald Transcript
Harbormaster completed remote builds in B108072: Diff 350416.Jun 7 2021, 2:41 PM
dblaikie added a comment.Sep 19 2021, 2:35 PM

Ping

dblaikie added a comment.Sep 28 2021, 11:21 AM

ping

dblaikie abandoned this revision.Oct 21 2021, 1:47 PM

Abandon in favor of D112265

Herald added a subscriber: carlosgalvezp. · View Herald TranscriptOct 21 2021, 1:47 PM

Revision Contents

PathSize
parallel-libs/
19 lines
acxxel/

Diff 350416

parallel-libs/.clang-tidy

Checks: '-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,readability-identifier-naming' Checks: '-llvm-header-guard'
CheckOptions: InheritParentConfig: true
- key: readability-identifier-naming.ClassCase
value: CamelCase
- key: readability-identifier-naming.EnumCase
value: CamelCase
- key: readability-identifier-naming.FunctionCase
value: lowerCase
- key: readability-identifier-naming.MemberCase
value: CamelCase
- key: readability-identifier-naming.ParameterCase
value: CamelCase
- key: readability-identifier-naming.UnionCase
value: CamelCase
- key: readability-identifier-naming.VariableCase
value: CamelCase

parallel-libs/acxxel/.clang-tidy

  • This file was deleted.
Checks: '-*,clang-diagnostic-*,llvm-*,-llvm-header-guard,misc-*,-misc-unused-parameters,readability-identifier-naming'
CheckOptions:
- key: readability-identifier-naming.ClassCase
value: CamelCase
- key: readability-identifier-naming.EnumCase
value: CamelCase
- key: readability-identifier-naming.FunctionCase
value: camelBack
- key: readability-identifier-naming.MemberCase
value: CamelCase
- key: readability-identifier-naming.ParameterCase
value: CamelCase
- key: readability-identifier-naming.UnionCase
value: CamelCase
- key: readability-identifier-naming.VariableCase
value: CamelCase