Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
| llvm/test/Analysis/CostModel/AArch64/ctlz.ll | ||
|---|---|---|
| 68 | This tests a 8 x 64 = 256 bit vector, which is already bigger than the vector register. | |
| 77 | And this tests a 512 bit vector. Having this tests here won't hurt anyone, but I don't think it adds much compared to the previous tests, so might as well remove this one. | |
| 113 | Same for this one. | |
| 192 | You could consider adding a 32 x i8 case here, i.e. a test/vector that is bigger than the register width. | |
| llvm/test/Analysis/CostModel/AArch64/ctpop.ll | ||
| 2 | And similar remarks here about the vector widths as in the previous file. | |
| 5 | Nit, typo: intstructions | |
Sorry, ignore my previous comments, I have spotted them now (with your help).
This looks like a good set of new cost-model tests to me.
Sorry if that wasn't clear, but you can keep this one.