Page MenuHomePhabricator

[lld/mac] Implement -reexport_framework, -reexport_library, -reexport-l
ClosedPublic

Authored by thakis on Jun 1 2021, 5:19 PM.

Details

Summary

These are slightly easier-to-use versions of -sub_library and -sub_umbrella.

Diff Detail

Event Timeline

thakis created this revision.Jun 1 2021, 5:19 PM
Herald added a reviewer: gkm. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: dang. · View Herald Transcript
thakis requested review of this revision.Jun 1 2021, 5:19 PM
thakis retitled this revision from [lld/mac] Implement -reexport_framework, -reexport_library, -reexport_l to [lld/mac] Implement -reexport_framework, -reexport_library, -reexport-l.Jun 1 2021, 5:26 PM
int3 accepted this revision.Jun 1 2021, 9:37 PM
int3 added inline comments.
lld/MachO/Driver.cpp
335–336

How about having a setter on DylibFile that sets both reexport and config->hasReexports?

(if you do add it, markReexport() can use it too)

This revision is now accepted and ready to land.Jun 1 2021, 9:37 PM

Thanks!

lld/MachO/Driver.cpp
335–336

I was planning on deleting config->hasReexports and computing it by walking over all dylib files in the one place we need it in a follow-up. (I need to add some tests around the interaction of dead_strip_dylibs and reexports, too.)

Herald added a project: Restricted Project. · View Herald TranscriptJun 2 2021, 3:37 AM