The patch implements microMIPSr6 CACHEE, WRPGPR and WSBH instructions.
Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
LGTM with some nits.
lib/Target/Mips/Disassembler/MipsDisassembler.cpp | ||
---|---|---|
1109–1117 | Indentation (labels are the same indentation level as the switch in LLVM's style). | |
lib/Target/Mips/MicroMips32r6InstrFormats.td | ||
47 | As per the other reviews, please assign these to fields named 'base' and 'offset' to make the special encoding self-documenting. bits<21> addr; bits<5> base = addr{20-16}; bits<9> offset = addr{8-0}; ... let Inst{20-16} = base; ... let Inst{8-0} = offset; | |
lib/Target/Mips/MicroMips32r6InstrInfo.td | ||
263 | wrpgpr isn't a 'word swap', it's a register move. | |
264 | 'WORDSWAP' is misleading. WSBH swaps bytes within each half-word (1234 -> 2143). |
Indentation (labels are the same indentation level as the switch in LLVM's style).