Add flang-x86_64-windows builder.

[Meinersbur]

Summary

Add a buildbot to compile flang using msvc. Due to msvc doing some things differently than other compilers, the msvc flang build breaks regularly. This builder will notify committers if their change causes the build to break.

However, the tests never completed successfully on Windows, partially because many tests require a UNIX shell (see D89368). To not constantly fail, tests failures only trigger a warning, until all tests are fixed as well.

Currently running here: http://meinersbur.de:8011/#/builders/146

[gkistanova]

Frankly, I don't like the idea of allowing failing tests, definitely not in production. I see what you want to achieve with this, though.

How about not running tests in production till they are working properly, and have them on in the staging? You will have about the same result - test failures will not be reported nor annotated in github, but those who are interested could see the failures, analyze the logs, and reference particular builds. Once all the failing tests are sorted out and passing, they will be enabled in the production. You would have to have at least 2 workers for this setup. Would this do?

buildbot/osuosl/master/config/builders.py

1621

Could you skip the clean arg to use the default, please?

[Meinersbur]

• Remove clean=False which is the default anyway.

[Meinersbur]

In D103199#2786354, @gkistanova wrote:

How about not running tests in production till they are working properly, and have them on in the staging? You will have about the same result - test failures will not be reported nor annotated in github, but those who are interested could see the failures, analyze the logs, and reference particular builds. Once all the failing tests are sorted out and passing, they will be enabled in the production. You would have to have at least 2 workers for this setup. Would this do?

While I like the idea, I only have one system for this. The most I could do is some scripting that alternate between two worker processes.

[Meinersbur]

• Remove allow_test_fail

Windows flang tests are now green after D104011 and D89368. allow_test_fail not required anymore.
See http://meinersbur.de:8011/#/builders/146/builds/593

[gkistanova]

LGTM

buildbot/osuosl/master/config/builders.py

'factory' : UnifiedTreeBuilder.getCmakeWithNinjaBuildFactory(
                         '-DLLVM_LIT_ARGS=-vj 256'
                     ],
                     env={
                         'CC': 'clang',
                         'CXX': 'clang++',
                         'LD': 'lld'
                     })},
 
+    {'name' : "flang-x86_64-windows",
+    'tags'  : ["flang"],
+    'workernames' : ["minipc-ryzen-win"],
+    'builddir': "flang-x86_64-windows",
+    'factory' : UnifiedTreeBuilder.getCmakeWithNinjaBuildFactory(
+                    depends_on_projects=['llvm','mlir','clang','flang'],
+                    checks=['check-flang'],
+                    install_dir="flang.install",
+                    extra_configure_args=[
+                        "-DCLANG_ENABLE_STATIC_ANALYZER=OFF",
+                        "-DCLANG_ENABLE_ARCMT=OFF",
+                        "-DCLANG_ENABLE_OBJC_REWRITER=OFF",
+                        "-DLLVM_TARGETS_TO_BUILD=X86",
+                        "-DLLVM_INSTALL_UTILS=ON",
+                        "-DCMAKE_C_COMPILER=cl",
+                        "-DCMAKE_CXX_COMPILER=cl",
+                        "-DCMAKE_CXX_STANDARD=17",
+                        '-DLLVM_PARALLEL_COMPILE_JOBS=4',
+                    ])},
+
 # Builders responsible building Sphinix documentation.
 
     {'name' : "llvm-sphinx-docs",
     'tags'  : ["llvm", "doc"],
     'workernames' : ["gribozavr3"],
     'builddir': "llvm-sphinx-docs",
     'factory': SphinxDocsBuilder.getSphinxDocsBuildFactory(llvm_html=True, llvm_man=True)},
 

buildbot/osuosl/master/config/workers.py

return [
 
         # Ubuntu 18.04.LTS x86_64, GCE instance
         create_worker("polly-x86_64-gce1", properties={'jobs': 2}, max_builds=1),
         create_worker("polly-x86_64-gce2", properties={'jobs': 2}, max_builds=1),
 
         # Ubuntu 18.04.LTS x86_64, Intel(R) Xeon(R) CPU X3460 @ 2.80GHz, 32 GiB RAM
         create_worker("polly-x86_64-fdcserver", properties={'jobs': 8, 'loadaverage': 8}, max_builds=1),
 
+        # Windows 10, AMD Ryzen 5 PRO 4650G, 16 GiB RAM
+        create_worker("minipc-ryzen-win", properties={'jobs': 12}, max_builds=1),
+
         # Ubuntu 20.04.LTS x86_64, Intel(R) Core(TM) i5-9400F CPU @ 2.90Ghz, 16 GiB RAM, NVIDIA GeForce GTX 1050 Ti (Pascal, sm_61, 4GiB)
         create_worker("minipc-1050ti-linux", properties={'jobs': 6}, max_builds=1),
 
         create_worker("nersc-flang"),
         create_worker("alcf-theta-flang", properties={'jobs': 12}, max_builds=1),
 
         # ML-Driven Compiler Optimizations build workers (Ubuntu x86_64)
         create_worker("ml-opt-dev-x86-64-b1",