This is an archive of the discontinued LLVM Phabricator instance.

Differential D103063

[AIX][test-suite] Disable the CLAMR benchmark on AIX
ClosedPublic

Authored by amyk on May 24 2021, 8:02 PM.

Details

Reviewers
daltenty
stevewan
hubert.reinterpretcast
Group Reviewers
Restricted Project
Commits
rT1cb64d378e95: [AIX][test-suite] Disable the CLAMR benchmark on AIX
Summary

This patch disables the CLAMR benchmark on AIX. This is because the benchmark utilizes the SLIST_* functions,
but these functions are not present within <sys/queue.h> on AIX.

Diff Detail

Repository
rT test-suite

Event Timeline

amyk created this revision.May 24 2021, 8:02 PM
Herald added a subscriber: mgorny. · View Herald TranscriptMay 24 2021, 8:02 PM
amyk requested review of this revision.May 24 2021, 8:02 PM
amyk added a comment.Jul 2 2021, 11:21 AM

Ping.

amyk added a comment.Jul 29 2021, 9:09 AM

Ping.

amyk added a subscriber: ZarkoCA.Aug 16 2021, 7:23 AM

Gentle ping.
@hubert.reinterpretcast @ZarkoCA @stevewan @daltenty Did any of you have any comments regarding this change?

amyk added a comment.Sep 14 2021, 10:05 AM

Gentle ping.

daltenty accepted this revision.Sep 14 2021, 11:15 AM

LGTM, the code this benchmark is looking for is using non-portable, non-POSIX, so it's not reasonable to expect this benchmark to build on AIX without portability work in the original application.

This revision is now accepted and ready to land.Sep 14 2021, 11:15 AM
Closed by commit rT1cb64d378e95: [AIX][test-suite] Disable the CLAMR benchmark on AIX (authored by amyk). · Explain WhyNov 19 2021, 7:48 AM
This revision was automatically updated to reflect the committed changes.
amyk added a commit: rT1cb64d378e95: [AIX][test-suite] Disable the CLAMR benchmark on AIX.
daltenty mentioned this in D146374: [test-suite] Disable CLAMR fmemopen() substitute function on FreeBSD / OpenBSD and AIX.Mar 22 2023, 9:49 PM

Revision Contents

PathSize
MultiSource/
Benchmarks/
DOE-ProxyApps-C++/
2 lines

Diff 388503

MultiSource/Benchmarks/DOE-ProxyApps-C++/CMakeLists.txt

add_subdirectory(HPCCG) add_subdirectory(HPCCG)
add_subdirectory(PENNANT) add_subdirectory(PENNANT)
add_subdirectory(miniFE) add_subdirectory(miniFE)
if(NOT CMAKE_SYSTEM_NAME MATCHES "AIX")
add_subdirectory(CLAMR) add_subdirectory(CLAMR)
endif()
add_subdirectory(HACCKernels) add_subdirectory(HACCKernels)