This is an archive of the discontinued LLVM Phabricator instance.

[libcxx][gardening] Re-order includes across libcxx.
ClosedPublic

Authored by zoecarver on May 21 2021, 1:15 PM.

Details

Summary

This commit alphabetizes all includes in libcxx. This is a NFC.

This can also serve as a pseudo "announcement" for how we should order these headers going forward (note: double underscores go before other headers).

Diff Detail

Event Timeline

zoecarver requested review of this revision.May 21 2021, 1:15 PM
zoecarver created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMay 21 2021, 1:15 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.May 21 2021, 1:20 PM

This can also serve as a pseudo "announcement" for how we should order these headers going forward (note: double underscores go before other headers).

Rather -- we always sort alphabetically, which means double underscores go where they go: before non-underscored headers, but it's really just mechanical.

libcxx/include/__ranges/data.h
12–13

We could remove the newline here and just include __config like any other header, in alphabetical order.

This revision is now accepted and ready to land.May 21 2021, 1:20 PM
This revision was landed with ongoing or failed builds.May 21 2021, 1:22 PM
This revision was automatically updated to reflect the committed changes.