This is an archive of the discontinued LLVM Phabricator instance.

[scudo] Add supported architectures.
ClosedPublic

Authored by hctim on May 17 2021, 12:54 PM.

Details

Summary

Adds extra supported architectures that were available for vanilla
scudo, in preparation for D102543. Hopefully the dust has settled and
7d0a81ca38e427de9b7fb0961ec643b757028131 is no longer an issue.

Diff Detail

Event Timeline

hctim created this revision.May 17 2021, 12:54 PM
hctim requested review of this revision.May 17 2021, 12:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2021, 12:54 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
vitalybuka accepted this revision.May 17 2021, 1:29 PM

I am not following why ARM32 is fixed?

This revision is now accepted and ready to land.May 17 2021, 1:29 PM
hctim added a comment.May 18 2021, 1:59 PM

Thanks for that. I'll rip some of the cmake commands out of that and try and drill down the bug on our aarch64 bot cross-compiling for armv7.

vitalybuka added a comment.EditedMay 18 2021, 9:35 PM

Thanks for that. I'll rip some of the cmake commands out of that and try and drill down the bug on our aarch64 bot cross-compiling for armv7.

Consider disabling the test for arm and landing the patch to avoid regression on working arm tests.

hctim updated this revision to Diff 346551.May 19 2021, 1:47 PM

Disable the buggy secondary test until we can figure out what's going on. I don't have access to any hardware that can reproduce the problem, and it doesn't seem to pop up on qemu arm32 user mode emulation. I tried an aarch64 machine, but apparently arm32 support is optional in armv8 and the CPU on that bot doesn't support arm32.

cryptoad accepted this revision.May 19 2021, 1:49 PM
vitalybuka accepted this revision.May 19 2021, 4:58 PM
vitalybuka added inline comments.
compiler-rt/lib/scudo/standalone/tests/secondary_test.cpp
36–44

there is a small change that config-ix.cmake will be reverted, so I would keep secondary_test.cpp in a separate patch

hctim added inline comments.May 20 2021, 10:20 AM
compiler-rt/lib/scudo/standalone/tests/secondary_test.cpp
36–44

Sounds good to me, I'll split this patch and submit them separately (test first, then cmake).

hctim marked an inline comment as done.May 20 2021, 10:20 AM

Partial commit in 577a80bff8bdf9b26c0f4ff6d1807e43da66ec6a with just the secondary_test.cpp changes.

This revision was landed with ongoing or failed builds.May 20 2021, 11:23 AM
This revision was automatically updated to reflect the committed changes.