[scudo] Add supported architectures.

[hctim]

Summary

Adds extra supported architectures that were available for vanilla
scudo, in preparation for D102543. Hopefully the dust has settled and
7d0a81ca38e427de9b7fb0961ec643b757028131 is no longer an issue.

[vitalybuka]

I am not following why ARM32 is fixed?

[vitalybuka]

Now the bot should cover this archs https://lab.llvm.org/buildbot/#/builders/70/builds/7283

[hctim]

In D102648#2766728, @vitalybuka wrote:

Now the bot should cover this archs https://lab.llvm.org/buildbot/#/builders/70/builds/7283

Thanks for that. I'll rip some of the cmake commands out of that and try and drill down the bug on our aarch64 bot cross-compiling for armv7.

[vitalybuka]

In D102648#2767064, @hctim wrote:

In D102648#2766728, @vitalybuka wrote:

Now the bot should cover this archs https://lab.llvm.org/buildbot/#/builders/70/builds/7283

Thanks for that. I'll rip some of the cmake commands out of that and try and drill down the bug on our aarch64 bot cross-compiling for armv7.

Consider disabling the test for arm and landing the patch to avoid regression on working arm tests.

[hctim]

Disable the buggy secondary test until we can figure out what's going on. I don't have access to any hardware that can reproduce the problem, and it doesn't seem to pop up on qemu arm32 user mode emulation. I tried an aarch64 machine, but apparently arm32 support is optional in armv8 and the CPU on that bot doesn't support arm32.

[vitalybuka]

compiler-rt/lib/scudo/standalone/tests/secondary_test.cpp

36–44

there is a small change that config-ix.cmake will be reverted, so I would keep secondary_test.cpp in a separate patch

[hctim]

compiler-rt/lib/scudo/standalone/tests/secondary_test.cpp

36–44

Sounds good to me, I'll split this patch and submit them separately (test first, then cmake).

[hctim]

Partial commit in 577a80bff8bdf9b26c0f4ff6d1807e43da66ec6a with just the secondary_test.cpp changes.

[vitalybuka]

Works here https://lab.llvm.org/buildbot/#/builders/169/builds/62

compiler-rt/cmake/config-ix.cmake

 set(VERS_COMPAT_OPTION "-Wl,-z,gnu-version-script-compat")
 compiler_rt_check_linker_flag("${VERS_COMPAT_OPTION}" COMPILER_RT_HAS_GNU_VERSION_SCRIPT_COMPAT)
 
 set(DUMMY_VERS ${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeTmp/dummy.vers)
 file(WRITE ${DUMMY_VERS} "{};")
 set(VERS_OPTION "-Wl,--version-script,${DUMMY_VERS}")
 if(COMPILER_RT_HAS_GNU_VERSION_SCRIPT_COMPAT)
   # Solaris 11.4 ld only supports --version-script with
-  # -z gnu-version-script-compat. 
+  # -z gnu-version-script-compat.
   string(APPEND VERS_OPTION " ${VERS_COMPAT_OPTION}")
 endif()
 compiler_rt_check_linker_flag("${VERS_OPTION}" COMPILER_RT_HAS_VERSION_SCRIPT)
 
 if(ANDROID)
   compiler_rt_check_linker_flag("-Wl,-z,global" COMPILER_RT_HAS_Z_GLOBAL)
   check_library_exists(log __android_log_write "" COMPILER_RT_HAS_LIBLOG)
 endif()

 set(ALL_PROFILE_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${PPC32} ${PPC64}
     ${MIPS32} ${MIPS64} ${S390X} ${SPARC} ${SPARCV9})
 set(ALL_TSAN_SUPPORTED_ARCH ${X86_64} ${MIPS64} ${ARM64} ${PPC64})
 set(ALL_UBSAN_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${RISCV64}
     ${MIPS32} ${MIPS64} ${PPC64} ${S390X} ${SPARC} ${SPARCV9})
 set(ALL_SAFESTACK_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM64} ${MIPS32} ${MIPS64})
 set(ALL_CFI_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${MIPS64})
 set(ALL_SCUDO_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${MIPS32} ${MIPS64} ${PPC64})
-set(ALL_SCUDO_STANDALONE_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM64})
+set(ALL_SCUDO_STANDALONE_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${MIPS32} ${MIPS64} ${PPC64})
 if(APPLE)
 set(ALL_XRAY_SUPPORTED_ARCH ${X86_64})
 else()
 set(ALL_XRAY_SUPPORTED_ARCH ${X86_64} ${ARM32} ${ARM64} ${MIPS32} ${MIPS64} powerpc64le)
 endif()
 set(ALL_SHADOWCALLSTACK_SUPPORTED_ARCH ${ARM64})
 
 if (UNIX)

compiler-rt/lib/scudo/standalone/tests/secondary_test.cpp

template <typename Config> static void testSecondaryBasic(void) {
   std::unique_ptr<SecondaryT> L(new SecondaryT);
   L->init(&S);
   const scudo::uptr Size = 1U << 16;
   void *P = L->allocate(scudo::Options{}, Size);
   EXPECT_NE(P, nullptr);
   memset(P, 'A', Size);
   EXPECT_GE(SecondaryT::getBlockSize(P), Size);
   L->deallocate(scudo::Options{}, P);
+
+// TODO(hctim): Looks like the secondary pointer doesn't get unmapped on arm32.
+// It's not clear whether this is a kernel issue, or something in EXPECT_DEATH()
+// is mmap-ing something that uses the same vaddr space. For now, just disable
+// the test on arm32 until we can debug it further.
+#ifndef __arm__
   // If the Secondary can't cache that pointer, it will be unmapped.
   if (!L->canCache(Size))
     EXPECT_DEATH(memset(P, 'A', Size), "");
+#endif // __arm__
 
   const scudo::uptr Align = 1U << 16;
   P = L->allocate(scudo::Options{}, Size + Align, Align);
   EXPECT_NE(P, nullptr);
   void *AlignedP = reinterpret_cast<void *>(
       scudo::roundUpTo(reinterpret_cast<scudo::uptr>(P), Align));
   memset(AlignedP, 'A', Size);
   L->deallocate(scudo::Options{}, P);