This is an archive of the discontinued LLVM Phabricator instance.

[X86] Pre-commit test for D90901
ClosedPublic

Authored by Jim on May 17 2021, 6:24 AM.

Diff Detail

Event Timeline

Jim created this revision.May 17 2021, 6:24 AM
Jim requested review of this revision.May 17 2021, 6:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2021, 6:24 AM
spatel added a subscriber: spatel.May 20 2021, 5:43 AM
spatel added inline comments.
llvm/test/CodeGen/X86/fma-signed-zero.ll
4–5

We are moving away from global options that control FP state. Remove this RUN, and only use IR-level "nsz" fast-math-flags to show the differences.

If I'm seeing it correctly, the tests are already duplicated with/without the FMF, so this will only reduce the FileCheck lines.

Jim updated this revision to Diff 346911.May 20 2021, 7:43 PM

Address @spatel's comment.

Jim updated this revision to Diff 346912.May 20 2021, 7:45 PM

Update comment in the test.

spatel accepted this revision.May 21 2021, 5:10 AM

LGTM

This revision is now accepted and ready to land.May 21 2021, 5:10 AM
This revision was automatically updated to reflect the committed changes.